Skip to content

Documentation/bpf: Fix stale references in map docs

Ahmad Wicaksono bpf linux-doc 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Documentation/bpf: Update sockmap docs for mutation restrictionsDocumentation/bpf/map_sockmap.rst+16 -22 replies
2/2Documentation/bpf: Fix stale selftests file referencesDocumentation/bpf/btf.rst Documentation/bpf/map_lpm_trie.rst+4 -41 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJakub Sitnicki
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH bpf-next 0/2] Documentation/bpf: Fix stale references in map docs

Two documentation fixes for the BPF map pages.

Patch 1 records that since commit be39165224d0 ("bpf, sockmap: Disallow update and delete from tc, xdp, socket_filter and flow_dissector"), only BPF_TRACE_ITER tracing, sock_ops (delete only), sk_reuseport and sk_lookup programs may mutate a sockmap or sockhash; anything else is rejected with "cannot update sockmap in this context". The kernel-side sections of map_sockmap.rst did not mention this. It also drops the reference to progs/test_sockmap_update.c, removed by
commit 5de7a6eaed89 ("selftests/bpf: Drop tc/xdp/flow_dissector/socket_filter sockmap mutation tests").

Patch 2 fixes two moved selftests paths: test_lpm_map.c, now map_tests/lpm_trie_map_basic_ops.c, and test_xdp_noinline.c, now under progs/.

Documentation only; no functional change.

Ahmad Wicaksono (2):
Documentation/bpf: Update sockmap docs for mutation restrictions Documentation/bpf: Fix stale selftests file references

 Documentation/bpf/btf.rst          |  2 +-
 Documentation/bpf/map_lpm_trie.rst |  6 +++---
 Documentation/bpf/map_sockmap.rst  | 18 ++++++++++++++++--
 3 files changed, 20 insertions(+), 6 deletions(-)

checkpatch.pl --strict is clean. make SPHINXDIRS=bpf htmldocs gives identical warnings before and after. Documentation only, so nothing to run-test.

base-commit: ca4181cacb0c6a5632018f1c94f29d9dbc0e9270

Signature · 1 line
2.43.0