Skip to content

selftests: net: veth: propagate check failures to exit status

Omokefe Emmanuel Onanaroghene bpf linux-kselftest lkml netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 of 3 patches 2 repliesIn review
  2. v32 patches 2 repliesSuperseded
  3. v21 patch 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch0 repliesSuperseded

Changes in v4 from the cover letter

- Patch 2: use if/else instead of "&& { ...; } ||" chains, keep lines within 80 columns (thanks Tianyi for the review).
- Add patch 3 deriving the invalid tx value from the kernel maximum.

2 of 3 patches are in this archive. The cover letter announces 3.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3selftests: net: veth: propagate channel-check failures to exit statustools/testing/selftests/net/veth.sh+1 -00 replies
2/3selftests: net: veth: propagate bad-settings check failures to exit statustools/testing/selftests/net/veth.sh+19 -70 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchTianyi Gao
1/3T-b
2/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH net v4 0/3] selftests: net: veth: propagate check failures to exit status

Four checks in tools/testing/selftests/net/veth.sh report failures without setting ret, allowing the script to exit 0 even when a check fails. Set ret=1 in chk_channels() and the three "bad setting" negative tests identified by Tianyi during review of v2.

Patch 3 fixes the invalid TX channel test, which used nproc + 1 to determine an out-of-range value. However, nproc can be lower than num_possible_cpus() when CPU affinity or cpusets restrict a process, meaning the kernel may accept the requested queue count. This could cause false failures on a correctly functioning kernel once earlier patches propagated test failures.

Use the kernel-reported max_tx + 1 instead, ensuring the attempted value always exceeds the device's supported maximum. Spotted by Sashiko AI review of v2.

Changes v3 -> v4:
- Patch 2: use if/else instead of "&& { ...; } ||" chains, keep lines within 80 columns (thanks Tianyi for the review).
- Add patch 3 deriving the invalid tx value from the kernel maximum.

Changes v2 -> v3:
- Add Tianyi Gao's Tested-by to patch 1 (thanks!).
- Add patch 2 fixing the remaining three checks.

Changes v1 -> v2:
- Correct Fixes tag to 1ec2230fc721.

Omokefe Emmanuel Onanaroghene (3):
selftests: net: veth: propagate channel-check failures to exit status
selftests: net: veth: propagate bad-settings check failures to exit
status
selftests: net: veth: derive invalid-tx test value from kernel max

 tools/testing/selftests/net/veth.sh | 31 +++++++++++++++++++++--------
 1 file changed, 23 insertions(+), 8 deletions(-)
Signature · 1 line
2.43.0