Skip to content

iio: closing default trigger handling leaks

Jonathan Cameron linux-iio linux-media lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest35 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/35iio: core: add default_trigger and take reference in iio_device_register()drivers/iio/industrialio-core.c drivers/iio/industrialio-trigger.c include/linux/iio/iio.h+34 -61 reply
2/35media: pci: mgb4: use IIO default_triggerdrivers/media/pci/mgb4/mgb4_trigger.c+1 -10 replies
3/35iio: chemical: ens160: use default_triggerdrivers/iio/chemical/ens160_core.c+2 -30 replies
4/35iio: adc: ad4130: use default_triggerdrivers/iio/adc/ad4130.c+1 -10 replies
5/35iio: adc: ad4170-4: use default_triggerdrivers/iio/adc/ad4170-4.c+1 -10 replies
6/35iio: adc: ad7768-1: use default_triggerdrivers/iio/adc/ad7768-1.c+1 -11 reply
7/35iio: adc: ad7779: use default_triggerdrivers/iio/adc/ad7779.c+10 -100 replies
8/35iio: adc: ti-ads131e08: use default_triggerdrivers/iio/adc/ti-ads131e08.c+1 -10 replies
9/35iio: addac: ad74115: use default_triggerdrivers/iio/addac/ad74115.c+1 -10 replies
10/35iio: addac: ad74413r: use default_triggerdrivers/iio/addac/ad74413r.c+1 -10 replies
11/35iio: temperature: tmp006: use default_triggerdrivers/iio/temperature/tmp006.c+10 -120 replies
12/35iio: adc: ad4062: use default_triggerdrivers/iio/adc/ad4062.c+1 -10 replies
13/35iio: accel: bma220: use default_triggerdrivers/iio/accel/bma220_core.c+1 -12 replies
14/35iio: accel: bma400: use default_triggerdrivers/iio/accel/bma400_core.c+1 -11 reply
15/35iio: imu: smi330: use default_triggerdrivers/iio/imu/smi330/smi330_core.c+1 -20 replies
16/35iio: light: acpi-als: use default_triggerdrivers/iio/light/acpi-als.c+1 -10 replies
17/35iio: chemical: scd30: use default_triggerdrivers/iio/chemical/scd30_core.c+1 -10 replies
18/35iio: accel: bma180: use default_triggerdrivers/iio/accel/bma180.c+1 -11 reply
19/35iio: accel: kxcjk-1013: use default_triggerdrivers/iio/accel/kxcjk-1013.c+1 -10 replies
20/35iio: accel: mma8452: use default_triggerdrivers/iio/accel/mma8452.c+1 -10 replies
21/35iio: chemical: ccs811: use default_triggerdrivers/iio/chemical/ccs811.c+1 -10 replies
22/35iio: pressure: mpl3115: use default_triggerdrivers/iio/pressure/mpl3115.c+1 -10 replies
23/35iio: common: st_sensors: use default_triggerdrivers/iio/common/st_sensors/st_sensors_trigger.c+1 -11 reply
24/35iio: common: hid-sensors: use default_triggerdrivers/iio/common/hid-sensors/hid-sensor-trigger.c+2 -10 replies
25/35iio: pressure: bmp280: use default_triggerdrivers/iio/pressure/bmp280-core.c+1 -11 reply
26/35iio: light: vl6180: use default_triggerdrivers/iio/light/vl6180.c+1 -10 replies
27/35iio: gyro: itg3200: use default_triggerdrivers/iio/gyro/itg3200_buffer.c+1 -20 replies
28/35iio: imu: bmi160: use default_triggerdrivers/iio/imu/bmi160/bmi160.h drivers/iio/imu/bmi160/bmi160_core.c+11 -120 replies
29/35iio: accel: adxl355: use default_triggerdrivers/iio/accel/adxl355_core.c+9 -100 replies
30/35iio: gyro: adxrs290: use default_triggerdrivers/iio/gyro/adxrs290.c+9 -100 replies
31/35iio: accel: adxl372: use default_triggerdrivers/iio/accel/adxl372.c+1 -10 replies
32/35iio: light: si1145: use default_triggerdrivers/iio/light/si1145.c+1 -40 replies
33/35iio: adc: ti-tsc2046: use default_triggerdrivers/iio/adc/ti-tsc2046.c+1 -21 reply
34/35iio: accel: mxc4005: use default_triggerdrivers/iio/accel/mxc4005.c+1 -10 replies
35/35iio: gyro: mpu3050: use default_triggerdrivers/iio/gyro/mpu3050-core.c+1 -11 reply

Reviews trailers per patch

8 of 35 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLinus WalleijOleksij RempelPetre RodanAndy ShevchenkoJoshua Crofts
SeriesR-b R-b
1/35R-b
2/35
3/35
4/35
5/35
6/35
7/35
8/35
9/35
10/35
11/35
12/35
13/35R-b T-b
14/35R-b
15/35
16/35
17/35
18/35R-b
19/35
20/35
21/35
22/35
23/35R-b
24/35
25/35R-b
26/35
27/35
28/35
29/35
30/35
31/35
32/35
33/35R-b
34/35
35/35R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 00/35] iio: closing default trigger handling leaks

From: Jonathan Cameron <[email protected]>

Note this is compile tested only! I definitely want a few people to test that I didn't break everything.

This is the first part of what I think is a long term solution to the currently really fragile ordering constraints around setting default triggers. Today these are set by iio_dev->trig = iio_trigger_get(trig). The reference is only released on the iio_dev.release callback and only if we have set the mode to include one that means there might be a trigger set. That mode set only occurs when a buffer is registered. Thus trigger release only works if we have already registered a buffer.

One solution would be to reorder so that the default trigger is always set after the buffer registration (we have had various recent proposed patches to do that for individual drivers) but that is non obvious and fragile.

The solution here is easier to reason about. Decouple the setting of the default trigger from the acquisition of a reference. Thus we can acquire the reference in iio_device_register() when we know all the conditions for it's release have been achieved. So that's all we do in this part 1 series.

Part 2 will address immutable triggers and those that are effectively immutable but predate that logic. That is those that set a one to one relationship between device and trigger. That change is rather less mechanical than this one and 35 patches is really a bit big anyway even if most of them are small!

Part 3 and beyond will move to a situation where the iio_dev->trig will become opaque. That should stop anyone manipulating that directly. I have a few related cunning plans to test out before we get to that, not because the particular challenge is hard, but because they will trample on the same code.

Jonathan Cameron (35):
iio: core: add default_trigger and take reference in
iio_device_register()
media: pci: mgb4: use IIO default_trigger
iio: chemical: ens160: use default_trigger
iio: adc: ad4130: use default_trigger
iio: adc: ad4170-4: use default_trigger
iio: adc: ad7768-1: use default_trigger
iio: adc: ad7779: use default_trigger
iio: adc: ti-ads131e08: use default_trigger
iio: addac: ad74115: use default_trigger
iio: addac: ad74413r: use default_trigger
iio: temperature: tmp006: use default_trigger
iio: adc: ad4062: use default_trigger
iio: accel: bma220: use default_trigger
iio: accel: bma400: use default_trigger
iio: imu: smi330: use default_trigger
iio: light: acpi-als: use default_trigger
iio: chemical: scd30: use default_trigger
iio: accel: bma180: use default_trigger
iio: accel: kxcjk-1013: use default_trigger
iio: accel: mma8452: use default_trigger
iio: chemical: ccs811: use default_trigger
iio: pressure: mpl3115: use default_trigger
iio: common: st_sensors: use default_trigger
iio: common: hid-sensors: use default_trigger
iio: pressure: bmp280: use default_trigger
iio: light: vl6180: use default_trigger
iio: gyro: itg3200: use default_trigger
iio: imu: bmi160: use default_trigger
iio: accel: adxl355: use default_trigger
iio: gyro: adxrs290: use default_trigger
iio: accel: adxl372: use default_trigger
iio: light: si1145: use default_trigger
iio: adc: ti-tsc2046: use default_trigger
iio: accel: mxc4005: use default_trigger
iio: gyro: mpu3050: use default_trigger

 drivers/iio/accel/adxl355_core.c              | 19 ++++++++--------
 drivers/iio/accel/adxl372.c                   |  2 +-
 drivers/iio/accel/bma180.c                    |  2 +-
 drivers/iio/accel/bma220_core.c               |  2 +-
 drivers/iio/accel/bma400_core.c               |  2 +-
 drivers/iio/accel/kxcjk-1013.c                |  2 +-
 drivers/iio/accel/mma8452.c                   |  2 +-
 drivers/iio/accel/mxc4005.c                   |  2 +-
 drivers/iio/adc/ad4062.c                      |  2 +-
 drivers/iio/adc/ad4130.c                      |  2 +-
 drivers/iio/adc/ad4170-4.c                    |  2 +-
 drivers/iio/adc/ad7768-1.c                    |  2 +-
 drivers/iio/adc/ad7779.c                      | 20 ++++++++---------
 drivers/iio/adc/ti-ads131e08.c                |  2 +-
 drivers/iio/adc/ti-tsc2046.c                  |  3 +--
 drivers/iio/addac/ad74115.c                   |  2 +-
 drivers/iio/addac/ad74413r.c                  |  2 +-
 drivers/iio/chemical/ccs811.c                 |  2 +-
 drivers/iio/chemical/ens160_core.c            |  5 ++---
 drivers/iio/chemical/scd30_core.c             |  2 +-
 .../common/hid-sensors/hid-sensor-trigger.c   |  3 ++-
 .../common/st_sensors/st_sensors_trigger.c    |  2 +-
 drivers/iio/gyro/adxrs290.c                   | 19 ++++++++--------
 drivers/iio/gyro/itg3200_buffer.c             |  3 +--
 drivers/iio/gyro/mpu3050-core.c               |  2 +-
 drivers/iio/imu/bmi160/bmi160.h               |  1 -
 drivers/iio/imu/bmi160/bmi160_core.c          | 22 +++++++++----------
 drivers/iio/imu/smi330/smi330_core.c          |  3 +--
 drivers/iio/industrialio-core.c               | 15 ++++++++++---
 drivers/iio/industrialio-trigger.c            | 21 +++++++++++++++---
 drivers/iio/light/acpi-als.c                  |  2 +-
 drivers/iio/light/si1145.c                    |  5 +----
 drivers/iio/light/vl6180.c                    |  2 +-
 drivers/iio/pressure/bmp280-core.c            |  2 +-
 drivers/iio/pressure/mpl3115.c                |  2 +-
 drivers/iio/temperature/tmp006.c              | 22 +++++++++----------
 drivers/media/pci/mgb4/mgb4_trigger.c         |  2 +-
 include/linux/iio/iio.h                       |  4 ++++
 38 files changed, 114 insertions(+), 97 deletions(-)

base-commit: 94921bc9eb214f838481faa847cda5c42e486013

Signature · 1 line
2.56.1