Skip to content

af_unix: Drop MSG_OOB support.

Kuniyuki Iwashima bpf linux-security-module netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesApplied 4/4

Patches in v1 All 4 applied

#Subject and filesSizeRepliesApplied
1/4selftests: landlock: Replace MSG_OOB with O_ASYNC+F_SETSIG.tools/testing/selftests/landlock/config tools/testing/selftests/landlock/scoped_signal_test.c+22 -341 replyApplied
2/4selftests: bpf: sockmap: Remove AF_UNIX MSG_OOB test case.tools/testing/selftests/bpf/prog_tests/sockmap_redir.c+11 -342 repliesApplied
3/4selftests: af_unix: Remove MSG_OOB tests.tools/testing/selftests/net/af_unix/.gitignore tools/testing/selftests/net/af_unix/Makefile tools/testing/selftests/net/af_unix/config +2 more+1 -10050 repliesApplied
4/4af_unix: Remove MSG_OOB.include/net/af_unix.h include/net/dropreason-core.h net/unix/Kconfig +1 more+1 -2671 replyApplied

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchJiayuan Chen
1/4
2/4R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 net-next 0/4] af_unix: Drop MSG_OOB support.

MSG_OOB implementation is quite buggy and has received many CVEs, which led to CONFIG_AF_UNIX_OOB, but the default is 'y' so it is enabled by major distros, even though there is no clear use case.

In addition, such bugs have changed user-visible MSG_OOB behaviour many times, but no one complained about that.

MSG_OOB is often used to upgrade a trivial bug to LPE.

We do not have good reason to maintain such an unused feature and expose many users to risk.

This series drops MSG_OOB support.

Kuniyuki Iwashima (4):
selftests: landlock: Replace MSG_OOB with O_ASYNC+F_SETSIG.
selftests: bpf: sockmap: Remove AF_UNIX MSG_OOB test case.
selftests: af_unix: Remove MSG_OOB tests.
af_unix: Remove MSG_OOB.

 include/net/af_unix.h                         |   3 -
 include/net/dropreason-core.h                 |   6 -
 net/unix/Kconfig                              |   7 -
 net/unix/af_unix.c                            | 252 +----
 .../selftests/bpf/prog_tests/sockmap_redir.c  |  45 +-
 tools/testing/selftests/landlock/config       |   1 -
 .../selftests/landlock/scoped_signal_test.c   |  55 +-
 .../testing/selftests/net/af_unix/.gitignore  |   1 -
 tools/testing/selftests/net/af_unix/Makefile  |   1 -
 tools/testing/selftests/net/af_unix/config    |   1 -
 tools/testing/selftests/net/af_unix/msg_oob.c | 958 ------------------
 .../selftests/net/af_unix/scm_rights.c        |  45 +-
 12 files changed, 35 insertions(+), 1340 deletions(-)
 delete mode 100644 tools/testing/selftests/net/af_unix/msg_oob.c
Signature · 1 line
2.56.0.611.g1030f0b940-goog