Skip to content

nvme: use kfree_sensitive() for DH-HMAC-CHAP secrets

Martin George linux-nvme 1 version Applied

Status from this message: Thanks, applied to nvme-7.4.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2nvme-sysfs: use kfree_sensitive() for DH-HMAC-CHAP secretsdrivers/nvme/host/sysfs.c+6 -62 replies
2/2nvme-fabrics: use kfree_sensitive() for the old DH-HMAC-CHAP secretdrivers/nvme/host/fabrics.c+2 -22 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchHannes ReineckeChristoph Hellwig
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] nvme: use kfree_sensitive() for DH-HMAC-CHAP secrets

The host side stores the raw DH-HMAC-CHAP secret ("DHHC-1:...") but frees it with plain kfree() in a few places, leaving the secret in freed slab until the memory is reused. Switch those kfrees to kfree_sensitive() so the contents are wiped on free.

This is a hardening-only series; it fixes no functional bug and changes no behaviour.

Martin George (2):
nvme-sysfs: use kfree_sensitive() for DH-HMAC-CHAP secrets
nvme-fabrics: use kfree_sensitive() for the old DH-HMAC-CHAP secret

 drivers/nvme/host/fabrics.c |  4 ++--
 drivers/nvme/host/sysfs.c   | 12 ++++++------
 2 files changed, 8 insertions(+), 8 deletions(-)
Signature · 1 line
2.53.0