Skip to content

s390: Add __must_check to set_memory() primitives

Heiko Carstens linux-s390 lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8s390/kfence: Add error handling to arch_kfence_init_pool()arch/s390/include/asm/kfence.h+2 -10 replies
2/8s390/kprobes: Add error handling to alloc_insn_page()arch/s390/kernel/kprobes.c+4 -10 replies
3/8s390/kexec: Let crash_protect_pages() warn in case of an errorarch/s390/kernel/machine_kexec.c+5 -20 replies
4/8s390/module: Add error handling to module_alloc_ftrace_hotpatch_trampolines()arch/s390/kernel/module.c+6 -10 replies
5/8s390/mm: Add error handling to arch_setup_zero_pages()arch/s390/mm/init.c+4 -10 replies
6/8s390/mm: Add error handling to mark_rodata_ro()arch/s390/mm/init.c+4 -10 replies
7/8s390/mm: Add error handling to vmem_map_init()arch/s390/mm/vmem.c+9 -50 replies
8/8s390/set_memory: Add __must_check to set_memory() primitivesarch/s390/include/asm/set_memory.h+2 -20 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMike Rapoport (Microsoft)
SeriesA-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] s390: Add __must_check to set_memory() primitives

A small series which adds missing return value checks of set_memory() calls to s390 specific call sites. Also add __must_check to set_memory() primitives in order to avoid that new unchecked callers will be added.

This is basically the same what was done for powerpc with [1].

Note that this (trivially) conflicts with [2]. Furthermore the kexec code is the only call site which for now only prints an error message instead of really handling the error, since error handling in common code is missing. That needs to be added with later changes.

While doing this conversion I realized that s390's execmem support also can be improved. Will happen with a follow-on series.

[1] 2abbd6d5fbe0 ("powerpc: Add __must_check to set_memory_...()")
[2] https://lore.kernel.org/all/[email protected]/

Thanks,
Heiko

Heiko Carstens (8):
s390/kfence: Add error handling to arch_kfence_init_pool() s390/kprobes: Add error handling to alloc_insn_page() s390/kexec: Let crash_protect_pages() warn in case of an error s390/module: Add error handling to module_alloc_ftrace_hotpatch_trampolines() s390/mm: Add error handling to arch_setup_zero_pages()
s390/mm: Add error handling to mark_rodata_ro()
s390/mm: Add error handling to vmem_map_init()
s390/set_memory: Add __must_check to set_memory() primitives

 arch/s390/include/asm/kfence.h     |  3 ++-
 arch/s390/include/asm/set_memory.h |  4 ++--
 arch/s390/kernel/kprobes.c         |  5 ++++-
 arch/s390/kernel/machine_kexec.c   |  7 +++++--
 arch/s390/kernel/module.c          |  7 ++++++-
 arch/s390/mm/init.c                | 10 ++++++++--
 arch/s390/mm/vmem.c                | 14 +++++++++-----
 7 files changed, 36 insertions(+), 14 deletions(-)

base-commit: 666539eecdf4db623f5e3c3e55cf9f2dfad24aa4

Signature · 1 line
2.56.1