Skip to content

btrfs: zoned: RAID1 block groups with missing or stale stripes

Miroslav Cimerman linux-btrfs lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 1 replyIn review
  2. v14 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- 2/5: was 3/4, moved before 3/5, which needs the block group's capacity. It takes the capacity from all present stripes now
- 3/5: new. v1 failed a degraded mount with all devices present and full zones of different capacities, which loaded before when stripe 0 had the smallest one (found in an LLM review). Zones with an extent past the capacity are not capped
- 4/5 (was 2/4): mark a metadata block group with a mismatch active if any of its zones is. With an empty first zone, it stayed inactive and warned at its next write (reported by Sashiko)
- 5/5: add cases with an empty first zone, with different zone capacities and with a failed zone report, and a capacity per stripe. Renamed, as 6 of the 14 new cases are on a regular mount
- rebased on for-next 184fa2c40f5c

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5btrfs: zoned: take the RAID1 active state from the first present stripefs/btrfs/zoned.c+6 -20 replies
2/5btrfs: zoned: take the RAID1 zone capacity from all present stripesfs/btrfs/zoned.c+3 -10 replies
3/5btrfs: zoned: cap full RAID1 zones at the block group's capacityfs/btrfs/zoned.c+43 -00 replies
4/5btrfs: zoned: use the highest RAID1 write pointer on degraded mountsfs/btrfs/zoned.c+38 -91 reply
5/5btrfs: tests: zoned: add RAID1 cases with missing or stale stripesfs/btrfs/tests/zoned-tests.c+201 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/5] btrfs: zoned: RAID1 block groups with missing or stale stripes

btrfs_load_block_group_raid1() compares the active state and the write pointer of each present stripe with stripe 0's, and takes the zone capacity from stripes 0 and 1. But stripe 0 can be missing, any stripe can be behind the others on a degraded mount, and the full zones of a block group can report different capacities.

- 1/5 compares the active state with the first present stripe. With stripe 0 missing, such block groups were left off the active list, and writes to them could hang.
- 2/5 takes the zone capacity from all present stripes. RAID1C3 and RAID1C4 block groups failed to load with stripes 0 and 1 missing, once they held data, and were written past a smaller third or fourth stripe.
- 3/5 takes a full zone with more capacity than the block group as written up to the block group's capacity, unless an extent ends past it. Before, a regular mount failed on such block groups.
- 4/5 allocates from the highest write pointer on degraded mounts. Stripe 0's can be behind, and new extents then went over committed ones. It also lets a regular mount load a block group whose stripe 0 is on an offline or read-only zone.
- 5/5 adds self-test cases.

v2:
- 2/5: was 3/4, moved before 3/5, which needs the block group's capacity. It takes the capacity from all present stripes now
- 3/5: new. v1 failed a degraded mount with all devices present and full zones of different capacities, which loaded before when stripe 0 had the smallest one (found in an LLM review). Zones with an extent past the capacity are not capped
- 4/5 (was 2/4): mark a metadata block group with a mismatch active if any of its zones is. With an empty first zone, it stayed inactive and warned at its next write (reported by Sashiko)
- 5/5: add cases with an empty first zone, with different zone capacities and with a failed zone report, and a capacity per stripe. Renamed, as 6 of the 14 new cases are on a regular mount
- rebased on for-next 184fa2c40f5c

v1: https://lore.kernel.org/linux-btrfs/[email protected]/

Miroslav Cimerman (5):
btrfs: zoned: take the RAID1 active state from the first present
stripe
btrfs: zoned: take the RAID1 zone capacity from all present stripes
btrfs: zoned: cap full RAID1 zones at the block group's capacity
btrfs: zoned: use the highest RAID1 write pointer on degraded mounts
btrfs: tests: zoned: add RAID1 cases with missing or stale stripes

 fs/btrfs/tests/zoned-tests.c | 203 ++++++++++++++++++++++++++++++++++-
 fs/btrfs/zoned.c             | 102 +++++++++++++++---
 2 files changed, 291 insertions(+), 14 deletions(-)

base-commit: 184fa2c40f5c50afb1d8bf900eafadf450db392e

Signature · 1 line
2.53.0