Skip to content

RFC ASoC: atmel: mchp-spdifrx: Fix format handling and MR configuration

[email protected] linux-arm-kernel linux-sound lkml sashiko-reviews 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ASoC: atmel: mchp-spdifrx: Fix 16-bit big-endian format checksound/soc/atmel/mchp-spdifrx.c+1 -11 reply
2/2ASoC: atmel: mchp-spdifrx: Preserve MR defaults in hw_paramssound/soc/atmel/mchp-spdifrx.c+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/2] ASoC: atmel: mchp-spdifrx: Fix format handling and MR configuration

From: bui duc phuc <[email protected]>

Hi all,

This series addresses two issues in the mchp-spdifrx driver: inconsistent handling of the 16-bit big-endian format and MR register updates in hw_params().

This series was developed on top of the previous series:
https://lore.kernel.org/all/[email protected]/

Since this is an RFC series, I have kept it separate rather than including these changes in the previous series. The previous series should be applied first to avoid conflicts when applying these patches.

The changes are not hardware-tested, and I would appreciate feedback from someone with access to the hardware.

In particular, the MR register change needs verification. If the current code works as expected, the existing full-register write in hw_params() may be intentional, and the actual issue could instead be the default configuration in dai_probe().

For the 16-bit big-endian format, the current format check is clearly inconsistent with MCHP_SPDIF_FORMATS. However, it is also possible that the advertised format should be corrected instead of changing the check in hw_params(). Furthermore, I could not find datasheet documentation confirming support for big-endian 16-bit and 20-bit formats.

Therefore, hardware testing is needed to determine whether these changes are correct.

Compile-tested only.

Best regards,
Phuc

bui duc phuc (2):
ASoC: atmel: mchp-spdifrx: Fix 16-bit big-endian format check
ASoC: atmel: mchp-spdifrx: Preserve MR defaults in hw_params

 sound/soc/atmel/mchp-spdifrx.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Signature · 1 line
2.43.0