Skip to content

fs/ntfs3: Refactoring of several functions

Konstantin Komarov linux-fsdevel lkml ntfs3 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6fs/ntfs3: New function ntfs_bad_inodefs/ntfs3/attrib.c fs/ntfs3/frecord.c fs/ntfs3/fsntfs.c +3 more+25 -170 replies
2/6fs/ntfs3: Refactoring attr_set_size to restore after errorsfs/ntfs3/attrib.c+126 -540 replies
3/6fs/ntfs3: Refactoring attr_punch_hole to restore after errorsfs/ntfs3/attrib.c fs/ntfs3/ntfs_fs.h fs/ntfs3/run.c+105 -381 reply
4/6fs/ntfs3: Refactoring attr_insert_range to restore after errorsfs/ntfs3/attrib.c+86 -290 replies
5/6fs/ntfs3: Create MFT zone only if length is large enoughfs/ntfs3/fsntfs.c+3 -80 replies
6/6fs/ntfs3: Make ni_ins_new_attr return errorfs/ntfs3/frecord.c+26 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] fs/ntfs3: Refactoring of several functions

6 commits, that hopefully improves code (tests are ok). While working on attr_set_size, attr_punch_hole and attr_insert_range I've noticed how convoluted the code is.
I'll think about how to make code less complex.

Konstantin Komarov (6):
fs/ntfs3: New function ntfs_bad_inode
fs/ntfs3: Refactoring attr_set_size to restore after errors fs/ntfs3: Refactoring attr_punch_hole to restore after errors fs/ntfs3: Refactoring attr_insert_range to restore after errors fs/ntfs3: Create MFT zone only if length is large enough fs/ntfs3: ni_ins_new_attr now returns error

 fs/ntfs3/attrib.c  | 416 +++++++++++++++++++++++++++++++--------------
 fs/ntfs3/frecord.c |  35 +++-
 fs/ntfs3/fsntfs.c  |  25 ++-
 fs/ntfs3/inode.c   |   6 +-
 fs/ntfs3/namei.c   |   4 +-
 fs/ntfs3/ntfs_fs.h |   3 +
 fs/ntfs3/run.c     |  25 +++
 7 files changed, 368 insertions(+), 146 deletions(-)
Signature · 1 line
2.37.0