Skip to content

rtc: rtc-cmos: Assorted ACPI-related cleanups and fixes

Rafael J. Wysocki linux-acpi linux-pm linux-rtc lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am 5640233.DvuYhMxLoT@kreacher

Versions newest first · linked by author and title

  1. v2 Latest5 patches 3 repliesApplied
  2. v15 patches 9 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5rtc: rtc-cmos: Call cmos_wake_setup() from cmos_do_probe()drivers/rtc/rtc-cmos.c+22 -250 replies
2/5rtc: rtc-cmos: Call rtc_wake_setup() from cmos_do_probe()drivers/rtc/rtc-cmos.c+12 -160 replies
3/5rtc: rtc-cmos: Eliminate forward declarations of some functionsdrivers/rtc/rtc-cmos.c+149 -1550 replies
4/5rtc: rtc-cmos: Rename ACPI-related functionsdrivers/rtc/rtc-cmos.c+6 -60 replies
5/5rtc: rtc-cmos: Disable ACPI RTC event on removaldrivers/rtc/rtc-cmos.c+15 -00 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy ShevchenkoZhang Rui
SeriesR-b R-b T-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] rtc: rtc-cmos: Assorted ACPI-related cleanups and fixes

Hi All,

This is a v2 of the series previously posted as

https://lore.kernel.org/linux-acpi/2276401.ElGaqSPkdT@kreacher/

The first three patches in the series have not changed since then (I have considered moving the last patch, which is a fix, to the front, but that turns out to be a bit cumbersome and not really worth the effort).

This series of patches does some assorted ACPI-related cleanups to the CMOS RTC driver:
- redundant static variable is dropped,
- code duplication is reduced,
- code is relocated so as to drop a few unnecessary forward declarations of functions,
- functions are renamed to avoid confusion,
and fixes up an issue in the driver removal path.

Thanks!