Skip to content

sh-pfc: Don't include mach/*.h headers were not required

Laurent Pinchart linux-arm-kernel linux-sh 1 version New

Get series with b4
b4 am 2297366.cgFF8sJl8f@avalon

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] sh-pfc: Don't include mach/*.h headers were not required

Hi Magnus,

Quoted 11 lines · On Wednesday 24 July 2013 23:44:05 Magnus Damm wrote:
Quoted 7 lines · Laurent Pinchart

Hello,

The (long) road to multiplatform kernels requires getting rid of mach/*.h headers in device drivers. This patch set removes some of the included mach headers from the sh-pfc driver. The only remaining one is mach/irqs.h, to get the irq_pin() macro. This will require more work, see
[1] for a discussion of the issue.

That's a blocker for some of the SoCs, right? I suppose the ones using a separate GPIO controller are OK as-is?

Yes. It's a multiplatform blocker for r8a73a4, r8a7740 and sh73a0. SoCs using a separate GPIO controller are fine (although the same problem might pop up for future SoCs with a separate GPIO controller if the GPIO IRQs are handled by a device separate from the GPIO controller).

Quoted 6 lines
Quoted 6 lines

The patches are based on v3.11-rc2. Linus, do you usually pick pinctrl patches from the list, or should I send you a pull request ?

[1]
http://www.mail-archive.com/linux-kernel at vger.kernel.org/msg473450.html

Quoted 8 lines
Quoted 4 lines

Laurent Pinchart (3):
sh-pfc: Remove unneeded mach/<soc>.h includes
sh-pfc: sh7372: Replace <mach/irqs.h> with <linux/sh_intc.h>
sh-pfc: sh73a0: Remove EXT_IRQ16L and EXT_IRQ16H macros

These are fine with me. Thanks for your help!

Thank you.

Signature · 3 lines
Regards,

Laurent Pinchart