Skip to content

PM: Make the core and pm_runtime_force_suspend/resume() agree more

Rafael J. Wysocki linux-pm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10PM: runtime: Introduce pm_runtime_no_support()include/linux/pm_runtime.h+14 -00 replies
2/10PM: sleep: core: Use pm_runtime_no_support() during set_active updatesdrivers/base/power/main.c+4 -20 replies
3/10PM: runtime: Use pm_runtime_no_support() in pm_runtime_force_suspend()drivers/base/power/runtime.c+5 -10 replies
4/10PM: runtime: Drop status check from pm_runtime_force_resume()drivers/base/power/runtime.c+1 -10 replies
5/10PM: runtime: Do not enable wakeup IRQs during system resumedrivers/base/power/runtime.c+0 -10 replies
6/10PM: sleep: Adjust check before setting power.must_resumedrivers/base/power/main.c drivers/base/power/runtime.c include/linux/pm_runtime.h+8 -80 replies
7/10PM: sleep: Clear the power.set_active upfrontdrivers/base/power/main.c+3 -40 replies
8/10PM: sleep: Make pm_runtime_force_resume() look at power.set_activedrivers/base/power/runtime.c include/linux/pm.h+27 -150 replies
9/10PM: sleep: Propagate power.set_active in dependency chainsdrivers/base/power/main.c+16 -90 replies
10/10PM: runtime: Discover the lack of runtime PM supportdrivers/base/power/main.c drivers/base/power/runtime.c include/linux/pm.h +1 more+34 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 00/10] PM: Make the core and pm_runtime_force_suspend/resume() agree more

Hi Everyone,

This series is a result of the discussion on a recently reported issue with device runtime PM status propagation during system resume and the resulting patches:

https://lore.kernel.org/linux-pm/[email protected]/
https://lore.kernel.org/linux-pm/[email protected]/

Overall, due to restrictions related to pm_runtime_force_suspend() and pm_runtime_force_resume(), it was necessary to limit the RPM_ACTIVE setting propagation to the parent of the first device in a dependency chain that turned out to have to be resumed during system resume even though it was runtime-suspended before system suspend.

Those restrictions are that (1) pm_runtime_force_suspend() attempts to suspend devices that have never had runtime PM enabled if their runtime PM status is currently RPM_ACTIVE and (2) pm_runtime_force_resume() will skip device whose runtime PM status is currently RPM_ACTIVE.

The purpose of this series is to eliminate the above restrictions and get pm_runtime_force_suspend() and pm_runtime_force_resume() to agree more with what the core does.

First off, it turns out that detecting devices that have never had runtime PM enabled is not really hard - it is sufficient to check their power.last_status data when runtime PM is disabled. If power.last_status is RPM_INVALID at that point, runtime PM has never been enabled for the given device, so patch [01/10] adds a helper function for checking that.

Patch [02/10] makes the PM core use the new function to avoid setting power.set_active for devices with no runtime PM support which really is a fixup on top of

https://lore.kernel.org/linux-pm/[email protected]/

Patch [03/10] modifies pm_runtime_force_suspend() to skip devices with no runtime PM support with the help of the new function.

Next, patch [04/10] uses the observation that the runtime PM status check in pm_runtime_force_resume() is redundant and drops that check.

Patch [05/10] removes the wakeirq enabling from the pm_runtime_force_resume() error path because it is not really a good idea to enable wakeirqs during system resume.

Patch [06/10] makes the PM core somewhat more consistent with pm_runtime_force_suspend() and patch [07/10] prepares it for the subsequent changes.

Patch [08/10] changes pm_runtime_force_resume() to handle the case in which the runtime PM status of the device has been updated by the core to RPM_ACTIVE after pm_runtime_force_suspend() left it in RPM_SUSPENDED.

Patch [09/10] restores the RPM_ACTIVE setting propagation to parents and suppliers, but it takes exceptions into account (for example, devices with no runtime PM support).

Finally, patch [10/10] adds a mechanism to discover cases in which runtime PM is disabled for a device permanently even though it has been enabled for that device at one point.

Please have a look and let me know if you see any problems.

Thanks!