Skip to content

PCI: ACPI: Get rid of struct pci_platform_pm_ops and clean up code

Rafael J. Wysocki linux-acpi linux-pci lkml llvm 2 versions – In review

Get series with b4
b4 am 1800633.tdWV9SEqCh@kreacher

Versions newest first · linked by author and title

  1. v2 Latest7 patches 15 repliesIn review
  2. v10 of 5 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7PCI: PM: Do not use pci_platform_pm_ops for Intel MID PMdrivers/pci/pci-mid.c drivers/pci/pci.c drivers/pci/pci.h+49 -300 replies
2/7PCI: ACPI: PM: Do not use pci_platform_pm_ops for ACPIdrivers/pci/pci-acpi.c drivers/pci/pci.c drivers/pci/pci.h+66 -3611 replies
3/7PCI: PM: Drop struct pci_platform_pm_opsdrivers/pci/pci.c drivers/pci/pci.h+0 -500 replies
4/7PCI: PM: Rearrange pci_target_state()drivers/pci/pci.c+9 -140 replies
5/7PCI: PM: Make pci_choose_state() call pci_target_state()drivers/pci/pci-acpi.c drivers/pci/pci.c+16 -410 replies
6/7PCI: PM: Do not call platform_pci_power_manageable() unnecessarilydrivers/pci/pci.c+5 -110 replies
7/7PCI: PM: Simplify acpi_pci_power_manageable()drivers/pci/pci-acpi.c+1 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] PCI: ACPI: Get rid of struct pci_platform_pm_ops and clean up code

Hi All,

As explained in the changelog of patch [2/7], using struct pci_platform_pm_ops for ACPI is not particularly beneficial, so it is better to get rid of it and call the functions pointed to by it directly from the PCI core.

However, struct pci_platform_pm_ops is also used by the Intel MID support code, but it is actually better to call the MID PM function directly from the PCI core either, which is done in patch [1/7].

After these changes, patch [3/7] removes struct pci_platform_pm_ops and the rest is just cleanups and some code consolidation on top of that.

Thanks!