Skip to content

of: functions to count number of elements and convert regulators

Heiko Stübner linux-devicetree lkml 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am 2573561.oCYNnnL0gm@phil

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3of: add functions to count number of elements in a propertydrivers/of/base.c include/linux/of.h+108 -01 reply
2/3regulator: gpio-regulator: do not open-code counting and access of dt array elementsdrivers/regulator/gpio-regulator.c+6 -91 reply
3/3regulator: ti-abb-regulator: do not open-code counting and access of dt array elementsdrivers/regulator/ti-abb-regulator.c+20 -231 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRob HerringGrant LikelyMark Rutland
SeriesA-b
1/3A-b A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/3] of: functions to count number of elements and convert regulators

In a different thread [0] Mark Rutland suggested that drivers should not repeatedly open-code the counting of array elements in a property as well as handling the format and endianes of the DTB, as these should be limited to the of_ helper functions.

Therefore the first patch introduces a set of helper functions for counting the number of u8,...,u64 elements in a property.

The second and third patch convert the two regulator drivers that use this pattern to instead use both of_property_count_u32_elemens as well as of_property_read_u32_index.

gpio-regulator change tested on a s3c2416-based device, ti-abb-regulator compile-tested only.

[0] https://lkml.org/lkml/2014/1/16/172

Heiko Stuebner (3):
of: add functions to count number of elements in a property
regulator: gpio-regulator: do not open-code counting and access of dt array elements
regulator: ti-abb-regulator: do not open-code counting and access of dt array elements

 drivers/of/base.c                    |   32 ++++++++++++++
 drivers/regulator/gpio-regulator.c   |   15 +++----
 drivers/regulator/ti-abb-regulator.c |   43 +++++++++----------
 include/linux/of.h                   |   76 ++++++++++++++++++++++++++++++++++
 4 files changed, 134 insertions(+), 32 deletions(-)
Signature · 1 line
1.7.10.4