Skip to content

r8169: revert two commits due to a regression

Heiner Kallweit netdev 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 1 replySuperseded

Changes in v2 from the cover letter

- improve commit message

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Revert "r8169: remove unneeded mmiowb barriers"drivers/net/ethernet/realtek/r8169.c+7 -10 replies
2/2Revert "r8169: make use of xmit_more and __netdev_sent_queue"drivers/net/ethernet/realtek/r8169.c+10 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 net 0/2] r8169: revert two commits due to a regression

Sander reported a regression (kernel panic, see[1]), therefore let's revert these commits. Removal of the barriers doesn't seem to contribute to the issue, the patch just overlaps with the problematic one and only reverting both patches was tested.

[1] https://marc.info/?t=154965066400001&r=1&w=2

v2:
- improve commit message

Heiner Kallweit (2):
Revert "r8169: remove unneeded mmiowb barriers" Revert "r8169: make use of xmit_more and __netdev_sent_queue"

 drivers/net/ethernet/realtek/r8169.c | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)
Signature · 1 line
2.20.1