Skip to content

net: add and use dev_get_tstats64

Heiner Kallweit netdev wireguard 3 versions – Applied

Status from this message: Applied, thank you!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 1 replyApplied
  2. v210 patches 6 repliesSuperseded
  3. v15 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- add atomic_long_t member rx_frame_errors in patch 3 for making counter updates atomic

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/10net: core: add dev_get_tstats64 as a ndo_get_stats64 implementationinclude/linux/netdevice.h net/core/dev.c+16 -00 replies
2/10net: dsa: use net core stats64 handlingnet/dsa/dsa.c net/dsa/dsa_priv.h net/dsa/slave.c+8 -300 replies
3/10tun: switch to net core provided statistics countersdrivers/net/tun.c+34 -870 replies
4/10ip6_tunnel: use ip_tunnel_get_stats64 as ndo_get_stats64 callbacknet/ipv6/ip6_tunnel.c+1 -310 replies
5/10net: switch to dev_get_tstats64drivers/net/bareudp.c drivers/net/geneve.c drivers/net/vxlan.c+4 -40 replies
6/10gtp: switch to dev_get_tstats64drivers/net/gtp.c+1 -10 replies
7/10wireguard: switch to dev_get_tstats64drivers/net/wireguard/device.c+1 -10 replies
8/10vti: switch to dev_get_tstats64net/ipv4/ip_vti.c net/ipv6/ip6_vti.c+2 -20 replies
9/10ipv4/ipv6: switch to dev_get_tstats64net/ipv4/ip_gre.c net/ipv4/ipip.c net/ipv6/ip6_gre.c +1 more+8 -80 replies
10/10net: remove ip_tunnel_get_stats64include/net/ip_tunnels.h net/ipv4/ip_tunnel_core.c+0 -110 replies

Reviews trailers per patch

4 of 10 patches have a Reviewed-by or Acked-by.

PatchFlorian FainelliVladimir OlteanHarald WelteJason A. Donenfeld
1/10R-b
2/10R-b T-b
3/10
4/10
5/10
6/10A-b
7/10R-b
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH net-next v3 00/10] net: add and use dev_get_tstats64

It's a frequent pattern to use netdev->stats for the less frequently accessed counters and per-cpu counters for the frequently accessed counters (rx/tx bytes/packets). Add a default ndo_get_stats64() implementation for this use case. Subsequently switch more drivers to use this pattern.

v2:
- add patches for replacing ip_tunnel_get_stats64 Requested additional migrations will come in a separate series.

v3:
- add atomic_long_t member rx_frame_errors in patch 3 for making counter updates atomic

Heiner Kallweit (10):
net: core: add dev_get_tstats64 as a ndo_get_stats64 implementation
net: dsa: use net core stats64 handling
tun: switch to net core provided statistics counters
ip6_tunnel: use ip_tunnel_get_stats64 as ndo_get_stats64 callback
net: switch to dev_get_tstats64
gtp: switch to dev_get_tstats64
wireguard: switch to dev_get_tstats64
vti: switch to dev_get_tstats64
ipv4/ipv6: switch to dev_get_tstats64
net: remove ip_tunnel_get_stats64

 drivers/net/bareudp.c          |   2 +-
 drivers/net/geneve.c           |   2 +-
 drivers/net/gtp.c              |   2 +-
 drivers/net/tun.c              | 121 +++++++++------------------------
 drivers/net/vxlan.c            |   4 +-
 drivers/net/wireguard/device.c |   2 +-
 include/linux/netdevice.h      |   1 +
 include/net/ip_tunnels.h       |   2 -
 net/core/dev.c                 |  15 ++++
 net/dsa/dsa.c                  |   7 +-
 net/dsa/dsa_priv.h             |   2 -
 net/dsa/slave.c                |  29 ++------
 net/ipv4/ip_gre.c              |   6 +-
 net/ipv4/ip_tunnel_core.c      |   9 ---
 net/ipv4/ip_vti.c              |   2 +-
 net/ipv4/ipip.c                |   2 +-
 net/ipv6/ip6_gre.c             |   6 +-
 net/ipv6/ip6_tunnel.c          |  32 +--------
 net/ipv6/ip6_vti.c             |   2 +-
 net/ipv6/sit.c                 |   2 +-
 20 files changed, 75 insertions(+), 175 deletions(-)
Signature · 1 line
2.29.2