Skip to content

ACPI: PM: s2idle: Fix possible suspend lock-up

Rafael J. Wysocki linux-acpi linux-pm lkml 1 version In review

Get series with b4
b4 am 2787005.CsmIKtZlk9@kreacher

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ACPI: EC: Rework flushing of pending workdrivers/acpi/ec.c+13 -230 replies
2/2ACPI: PM: s2idle: Rework ACPI events synchronizationdrivers/acpi/sleep.c+19 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ACPI: PM: s2idle: Fix possible suspend lock-up

Hi All,

The first patch in this series is a fix for a suspend-to-idle issues introduced in 5.4 (see its changelog for details).

The second one is more of an optimization, although some systems may need it too (depending on how fragile their platform firmware is).

Kenneth,

This series is roughly equivalent to the patch at

https://lore.kernel.org/linux-pm/CAJZ5v0h1Ro75++4xuCznkx6GNYd+G5NpMGP96z1jdh=dm9uZbw@mail.gmail.com/T/#m11ca9a14efe4e5193bbda69767595a5fb7bd5479

The main difference is that it flushes system_wq before ec_query_wq, but that should not really matter if the issue you saw in 5.4 is the one described in the changelog of patch [1/2].

Please test this series and let me know if it works for you too.

In case it does work, it would be good to know if patch [1/2] is sufficient to fix the suspend problem at least with ec_no_wakeup == 0 (it may not be sufficient with ec_no_wakeup == 1).

Thanks!