Skip to content

cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

Rafael J. Wysocki linux-acpi linux-pm lkml 1 version In review

Get series with b4
b4 am 2811202.iOFZ6YHztY@kreacher

Versions newest first

  1. v1 Latest3 patches 30 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3PM: QoS: Introduce frequency QoSinclude/linux/pm_qos.h kernel/power/qos.c+284 -012 replies
2/3cpufreq: Use per-policy frequency QoSdrivers/acpi/processor_driver.c drivers/acpi/processor_perflib.c drivers/acpi/processor_thermal.c +7 more+114 -1144 replies
3/3PM: QoS: Drop frequency QoS types from device PM QoSdrivers/base/power/qos.c include/linux/pm_qos.h+2 -760 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchViresh KumarDmitry OsipenkoSudeep Holla
SeriesA-b T-b
1/3
2/3Diagnosed-by T-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [RFT][PATCH 0/3] cpufreq / PM: QoS: Introduce frequency QoS and use it in cpufreq

Hi All,

The motivation for this series is to address the problem discussed here:

https://lore.kernel.org/linux-pm/5ad2624194baa2f53acc1f1e627eb7684c577a19.1562210705.git.viresh.kumar@linaro.org/T/#md2d89e95906b8c91c15f582146173dce2e86e99f

and also reported here:

https://lore.kernel.org/linux-pm/20191015155735.GA29105@bogus/

Plus, generally speaking, using the policy CPU as a proxy for the policy with respect to PM QoS does not feel particularly straightforward to me and adds extra complexity.

Anyway, the first patch adds frequency QoS that is based on "raw" PM QoS (kind of in analogy with device PM QoS) and is just about min and max frequency requests (no direct relationship to devices).

The second patch switches over cpufreq and its users to the new frequency QoS. [The Fixes: tag has been tentatively added to it.]

The third one removes frequency request types from device PM QoS.

Unfortunately, the patches are rather big, but also they are quite straightforward.

I didn't have the time to test this series, so giving it a go would be much appreciated.

Thanks,
Rafael