Skip to content

NTFS read-write driver GPL implementation by Paragon Software

Konstantin Komarov linux-fsdevel lkml ntfs3 27 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v27 Latest10 patches 27 repliesIn review
  2. v2610 patches 7 repliesSuperseded
  3. v2510 patches 0 repliesSuperseded
Earlier versions · 24
VersionPostedPatchesRepliesStatus
v2410 patches1 replySuperseded
v2310 patches1 replySuperseded
v2210 patches1 replySuperseded
v2110 patches5 repliesSuperseded
v2010 patches0 repliesSuperseded
v1910 patches0 repliesSuperseded
v1810 patches2 repliesSuperseded
v1710 patches20 repliesSuperseded
v1610 patches1 replySuperseded
v1510 patches0 repliesSuperseded
v1410 patches6 repliesSuperseded
v1310 patches0 repliesSuperseded
v1210 patches2 repliesSuperseded
v1110 patches8 repliesSuperseded
v1010 patches2 repliesSuperseded
v910 patches0 repliesSuperseded
v810 patches0 repliesSuperseded
v710 patches2 repliesSuperseded
v610 patches4 repliesSuperseded
v510 patches17 repliesSuperseded
v410 patches0 repliesSuperseded
v310 patches14 repliesSuperseded
v210 patches18 repliesSuperseded
v11 patch12 repliesSuperseded

Changes in v27 from the cover letter

- iov_iter_copy_from_user_atomic() replaced by copy_page_from_iter_atomic() and iov_iter_advance() removed

Patches in v27 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10fs/ntfs3: Add headers and misc filesfs/ntfs3/debug.h fs/ntfs3/ntfs.h fs/ntfs3/ntfs_fs.h +1 more+2492 -00 replies
2/10fs/ntfs3: Add initialization of super blockfs/ntfs3/fsntfs.c fs/ntfs3/index.c fs/ntfs3/inode.c +1 more+8717 -03 replies
3/10fs/ntfs3: Add bitmapfs/ntfs3/bitfunc.c fs/ntfs3/bitmap.c+1654 -01 reply
4/10fs/ntfs3: Add file operations and implementationfs/ntfs3/dir.c fs/ntfs3/file.c fs/ntfs3/frecord.c +3 more+7093 -04 replies
5/10fs/ntfs3: Add attrib operationsfs/ntfs3/attrib.c fs/ntfs3/attrlist.c fs/ntfs3/xattr.c+3584 -01 reply
6/10fs/ntfs3: Add compressionfs/ntfs3/lib/decompress_common.c fs/ntfs3/lib/decompress_common.h fs/ntfs3/lib/lib.h +3 more+2000 -00 replies
7/10fs/ntfs3: Add NTFS journalfs/ntfs3/fslog.c+5181 -01 reply
8/10fs/ntfs3: Add Kconfig, Makefile and docDocumentation/filesystems/ntfs3.rst fs/ntfs3/Kconfig fs/ntfs3/Makefile+189 -03 replies
9/10fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefilefs/Kconfig fs/Makefile+2 -00 replies
10/10fs/ntfs3: Add MAINTAINERSMAINTAINERS+7 -06 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v27 yet.

Read the v27 thread

Cover letter [PATCH v27 00/10] NTFS read-write driver GPL implementation by Paragon Software

This patch adds NTFS Read-Write driver to fs/ntfs3.

Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux Kernel.

This is fully functional NTFS Read-Write driver. Current version works with NTFS(including v3.1) and normal/compressed/sparse files and supports journal replaying.

We plan to support this version after the codebase once merged, and add new features and fix bugs. For example, full journaling support over JBD will be added in later updates.

v2:
- patch splitted to chunks (file-wise)
- build issues fixed
- sparse and checkpatch.pl errors fixed
- NULL pointer dereference on mkfs.ntfs-formatted volume mount fixed
- cosmetics + code cleanup

v3:
- added acl, noatime, no_acs_rules, prealloc mount options
- added fiemap support
- fixed encodings support
- removed typedefs
- adapted Kernel-way logging mechanisms
- fixed typos and corner-case issues

v4:
- atomic_open() refactored
- code style updated
- bugfixes

v5:
- nls/nls_alt mount options added
- Unicode conversion fixes
- Improved very fragmented files operations
- logging cosmetics

v6:
- Security Descriptors processing changed
added system.ntfs_security xattr to set
SD
- atomic_open() optimized
- cosmetics

v7:
- Security Descriptors validity checks added (by Mark Harmstone)
- atomic_open() fixed for the compressed file creation with directio case
- remount support
- temporarily removed readahead usage
- cosmetics

v8:
- Compressed files operations fixed

v9:
- Further cosmetics applied as suggested
by Joe Perches

v10:
- operations with compressed/sparse files on very fragmented volumes improved
- reduced memory consumption for above cases

v11:
- further compressed files optimizations: reads/writes are now skipping bufferization
- journal wipe to the initial state optimized (bufferization is also skipped)
- optimized run storage (re-packing cluster metainformation)
- fixes based on Matthew Wilcox feedback to the v10
- compressed/sparse/normal could be set for empty files with 'system.ntfs_attrib' xattr

v12:
- nls_alt mount option removed after discussion with Pali Rohar
- fixed ni_repack()
- fixed resident files transition to non-resident when size increasing

v13:
- nested_lock fix (lockdep)
- out-of-bounds read fix (KASAN warning)
- resident->nonresident transition fixed for compressed files
- load_nls() missed fix applied
- some sparse utility warnings fixes

v14:
- support for additional compression types (we've adapted WIMLIB's implementation, authored by Eric Biggers, into ntfs3)

v15:
- kernel test robot warnings fixed
- lzx/xpress compression license headers updated

v16:
- lzx/xpress moved to initial ntfs-3g plugin code
- mutexes instead of a global spinlock for compresions
- FALLOC_FL_PUNCH_HOLE and FALLOC_FL_COLLAPSE_RANGE implemented
- CONFIG_NTFS3_FS_POSIX_ACL added

v17:
- FALLOC_FL_COLLAPSE_RANGE fixed
- fixes for Mattew Wilcox's and Andy Lavr's concerns

v18:
- ntfs_alloc macro splitted into two ntfs_malloc + ntfs_zalloc
- attrlist.c: always use ntfs_cmp_names instead of memcmp; compare entry names only for entry with vcn == 0
- dir.c: remove unconditional ni_lock in ntfs_readdir
- fslog.c: corrected error case behavior
- index.c: refactored due to modification of ntfs_cmp_names; use rw_semaphore for read/write access to alloc_run and bitmap_run while ntfs_readdir
- run.c: separated big/little endian code in functions
- upcase.c: improved ntfs_cmp_names, thanks to Kari Argillander for idea and 'bothcase' implementation

v19:
- fixed directory bitmap for 2MB cluster size
- fixed rw_semaphore init for directories

v20:
- fixed issue with incorrect hidden/system attribute setting on root subdirectories
- use kvmalloc instead of kmalloc for runs array
- fixed index behavior on volumes with cluster size more than 4k
- current build info is added into module info instead of printing on insmod

v21:
- fixes for clang CFI checks
- fixed sb->s_maxbytes for 32bit clusters
- user.DOSATTRIB is no more intercepted by ntfs3
- corrected xattr limits; is used
- corrected CONFIG_NTFS3_64BIT_CLUSTER usage
- info about current build is added into module info and printing on insmod (by Andy Lavr's request)
note: v21 is applicable for 'linux-next' not older than 2021.01.28

v22:
- ntfs_cmp_names() fixed
- raise warning if 'nls->uni2char' fails
- hot fix free clusters code optimized
- use clang-format 11.0 instead of 10.0 to format code

v23:
- corrections for Kernel Test Robot warnings
- kmem_cache_create() utilized to allocate memory in bitmap.c
- cosmetics and comments thru the code

v24:
- BIO_MAX_PAGES -> BIO_MAX_VECS (fix for build issue of v23 vs linux-next)
- minor optimization for LogFile: do not fill it with -1, if it's already there
- index.c: removed 'inline' in definition of hdr_find_split() and hdr_insert_head()

v25:
- restore fs/Makefile in patch
- refactor ntfs_create_inode() to use error-valued pointer
- use mi_get_ref to fill MFT_REF
- minimize checkpatch.pl warnings: replace LogFile with \x24LogFile when printing

v26:
- fixed coccinelle warnings
- fslog.c: fix memory leak and memory overwrite

v27:
- iov_iter_copy_from_user_atomic() replaced by copy_page_from_iter_atomic() and iov_iter_advance() removed

Konstantin Komarov (10):
fs/ntfs3: Add headers and misc files fs/ntfs3: Add initialization of super block fs/ntfs3: Add bitmap
fs/ntfs3: Add file operations and implementation fs/ntfs3: Add attrib operations
fs/ntfs3: Add compression
fs/ntfs3: Add NTFS journal
fs/ntfs3: Add Kconfig, Makefile and doc fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile fs/ntfs3: Add MAINTAINERS

 Documentation/filesystems/ntfs3.rst |  107 +
 MAINTAINERS                         |    7 +
 fs/Kconfig                          |    1 +
 fs/Makefile                         |    1 +
 fs/ntfs3/Kconfig                    |   46 +
 fs/ntfs3/Makefile                   |   36 +
 fs/ntfs3/attrib.c                   | 2082 +++++++++++
 fs/ntfs3/attrlist.c                 |  456 +++
 fs/ntfs3/bitfunc.c                  |  135 +
 fs/ntfs3/bitmap.c                   | 1519 ++++++++
 fs/ntfs3/debug.h                    |   64 +
 fs/ntfs3/dir.c                      |  594 +++
 fs/ntfs3/file.c                     | 1130 ++++++
 fs/ntfs3/frecord.c                  | 3071 ++++++++++++++++
 fs/ntfs3/fslog.c                    | 5181 +++++++++++++++++++++++++++
 fs/ntfs3/fsntfs.c                   | 2542 +++++++++++++
 fs/ntfs3/index.c                    | 2641 ++++++++++++++
 fs/ntfs3/inode.c                    | 2034 +++++++++++
 fs/ntfs3/lib/decompress_common.c    |  332 ++
 fs/ntfs3/lib/decompress_common.h    |  352 ++
 fs/ntfs3/lib/lib.h                  |   26 +
 fs/ntfs3/lib/lzx_decompress.c       |  683 ++++
 fs/ntfs3/lib/xpress_decompress.c    |  155 +
 fs/ntfs3/lznt.c                     |  452 +++
 fs/ntfs3/namei.c                    |  578 +++
 fs/ntfs3/ntfs.h                     | 1238 +++++++
 fs/ntfs3/ntfs_fs.h                  | 1085 ++++++
 fs/ntfs3/record.c                   |  609 ++++
 fs/ntfs3/run.c                      | 1111 ++++++
 fs/ntfs3/super.c                    | 1500 ++++++++
 fs/ntfs3/upcase.c                   |  105 +
 fs/ntfs3/xattr.c                    | 1046 ++++++
 32 files changed, 30919 insertions(+)
 create mode 100644 Documentation/filesystems/ntfs3.rst
 create mode 100644 fs/ntfs3/Kconfig
 create mode 100644 fs/ntfs3/Makefile
 create mode 100644 fs/ntfs3/attrib.c
 create mode 100644 fs/ntfs3/attrlist.c
 create mode 100644 fs/ntfs3/bitfunc.c
 create mode 100644 fs/ntfs3/bitmap.c
 create mode 100644 fs/ntfs3/debug.h
 create mode 100644 fs/ntfs3/dir.c
 create mode 100644 fs/ntfs3/file.c
 create mode 100644 fs/ntfs3/frecord.c
 create mode 100644 fs/ntfs3/fslog.c
 create mode 100644 fs/ntfs3/fsntfs.c
 create mode 100644 fs/ntfs3/index.c
 create mode 100644 fs/ntfs3/inode.c
 create mode 100644 fs/ntfs3/lib/decompress_common.c
 create mode 100644 fs/ntfs3/lib/decompress_common.h
 create mode 100644 fs/ntfs3/lib/lib.h
 create mode 100644 fs/ntfs3/lib/lzx_decompress.c
 create mode 100644 fs/ntfs3/lib/xpress_decompress.c
 create mode 100644 fs/ntfs3/lznt.c
 create mode 100644 fs/ntfs3/namei.c
 create mode 100644 fs/ntfs3/ntfs.h
 create mode 100644 fs/ntfs3/ntfs_fs.h
 create mode 100644 fs/ntfs3/record.c
 create mode 100644 fs/ntfs3/run.c
 create mode 100644 fs/ntfs3/super.c
 create mode 100644 fs/ntfs3/upcase.c
 create mode 100644 fs/ntfs3/xattr.c

base-commit: 5a4cee98ea757e1a2a1354b497afdf8fafc30a20

Signature · 1 line
2.25.4