Skip to content

use interpreters to invoke scripts

Ujjwal Kumar linux-arm-kernel linux-ia64 linux-kbuild linux-kernel-mentees lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 7 repliesIn review
  2. v1 RFC2 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- Changes suggested by Masahiro Yamada

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2kconfig: use interpreters to invoke scriptsinit/Kconfig+8 -81 reply
2/2kbuild: use interpreters to invoke scriptsMakefile arch/arm64/kernel/vdso/Makefile arch/arm64/kernel/vdso32/Makefile +4 more+10 -106 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] use interpreters to invoke scripts

This patch series aims at removing the dependency on execute bit of the scripts in the kbuild system.

If not working with fresh clone of linux-next, clean the srctree:
make distclean
make tools/clean

To test the dependency on execute bits, I tried building the kernel after removing x-bits for all files in the repository. Removing execute bits:
for i in $(find -executable -type f); do chmod -x $i; done

Any attempts to configure (or build) the kernel fail because of 'Permission denied' on scripts with the following error:

$ make allmodconfig
sh: ./scripts/gcc-version.sh: Permission denied
init/Kconfig:34: syntax error
init/Kconfig:33: invalid statement
init/Kconfig:34: invalid statement
sh: ./scripts/ld-version.sh: Permission denied
init/Kconfig:39: syntax error
init/Kconfig:38: invalid statement
sh: ./scripts/clang-version.sh: Permission denied
init/Kconfig:49: syntax error
init/Kconfig:48: invalid statement
make[1]: *** [scripts/kconfig/Makefile:71: allmodconfig] Error 1
make: *** [Makefile:606: allmodconfig] Error 2

Changes:
- Adds specific interpreters (in Kconfig) to invoke scripts.

After this patch I could successfully do a kernel build without any errors.

- Again, adds specific interpreters to other parts of kbuild system.

I could successfully perform the following make targets after applying the PATCH 2/2:
make headerdep
make kselftest-merge
make rpm-pkg
make perf-tar-src-pkg
make ARCH=ia64 defconfig
ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make prepare

Following changes in PATCH 2/2 are not yet tested:
arch/arm64/kernel/vdso32/Makefile arch/nds32/kernel/vdso/Makefile scripts/Makefile.build

---
Changes in v2:

- Changes suggested by Masahiro Yamada

    $($(CONFIG_SHELL)    ->  $(shell $(CONFIG_SHELL)

Ujjwal Kumar (2):
kconfig: use interpreters to invoke scripts
kbuild: use interpreters to invoke scripts

 Makefile                          |  4 ++--
 arch/arm64/kernel/vdso/Makefile   |  2 +-
 arch/arm64/kernel/vdso32/Makefile |  2 +-
 arch/ia64/Makefile                |  4 ++--
 arch/nds32/kernel/vdso/Makefile   |  2 +-
 init/Kconfig                      | 16 ++++++++--------
 scripts/Makefile.build            |  2 +-
 scripts/Makefile.package          |  4 ++--
 8 files changed, 18 insertions(+), 18 deletions(-)

base-commit: 2cab4ac556258c14f6ec8d2157654e95556bbb31 --
2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees