small set of nvme cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 4 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] small set of nvme cleanups
Quoted 9 lines · Sagi Grimberg
Centralizes queue size settings for fabrics and removes redundant argument to nvme_disable/enable_ctrl.
Sagi Grimberg (4):
nvme: havenvme_init_identifysetctrl->cap
nvme: move sqsize setting to the core
nvme: don't pass cap tonvme_disable_ctrl
nvme: don't pass cap tonvme_enable_ctrl
Quoted 9 lines
drivers/nvme/host/core.c | 19 ++++++++++--------- drivers/nvme/host/fc.c | 12 +----------- drivers/nvme/host/nvme.h | 4 ++-- drivers/nvme/host/pci.c | 7 ++++--- drivers/nvme/host/rdma.c | 15 ++------------- drivers/nvme/host/tcp.c | 13 ++----------- drivers/nvme/target/loop.c | 12 +----------- 7 files changed, 22 insertions(+), 60 deletions(-)
The changes look fine except for 1 main issue:? All of the nvmf transports call nvme_enable_ctrl(), which still references ctrl->cap, before they call nvme_init_identify().
-- james