Add PWM polarity flag macro for DT
Get series with b4
b4 am 10033310.z2U2FSCElN@avalonVersions newest first · linked by author and title
- v2 Latest0 of 4 patches 0 repliesNew
- v12 patches 0 repliesSuperseded
Patches in v2 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/4] Add PWM polarity flag macro for DT
Hi Stephen,
Quoted 9 lines · On Thursday 18 July 2013 10:55:56 Stephen Warren wrote:
Quoted 4 lines · Laurent Pinchart
Hello,
Here's a small patch set that replaces PWM polarity numerical constants with macros in DT.
The series,
Reviewed-by Stephen Warren <[email protected]>
Quoted 7 lines
I'm (very very) slightly hesitant about patch 3/4, since it's moving towards all PWMs having to use the same specifier format, whereas specifiers are at least potentially binding-specific, not device-type-specific. However, consistency is good; there's no need to do something different just for the heck of it. Equally, there's nothing actually stopping a new binding from defining its own format rather than simply deferring to pwm.txt if it absolutely has to, so I think this will turn out fine.
Exactly, that's why I don't think it's an issue. pwm.txt defines a common format, individual bindings are free to use it or not.
Thierry, if you're fine with the patches, could you take them in your tree with Stephen's Reviewed-by, or should I report them and send you a pull request ?
Signature · 3 lines
Regards, Laurent Pinchart