Skip to content

cpufreq/sched: Improve synchronization of policy limits updates with schedutil

Rafael J. Wysocki linux-pm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 11 repliesIn review
  2. v15 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6cpufreq/sched: Fix the usage of CPUFREQ_NEED_UPDATE_LIMITSkernel/sched/cpufreq_schedutil.c+15 -32 replies
2/6cpufreq/sched: Explicitly synchronize limits_changed flag handlingkernel/sched/cpufreq_schedutil.c+24 -42 replies
3/6cpufreq/sched: Set need_freq_update in ignore_dl_rate_limit()kernel/sched/cpufreq_schedutil.c+4 -11 reply
4/6cpufreq: Rename __resolve_freq() to clamp_and_resolve_freq()drivers/cpufreq/cpufreq.c+7 -60 replies
5/6cpufreq: Avoid using inconsistent policy->min and policy->maxdrivers/cpufreq/cpufreq.c+36 -106 replies
6/6cpufreq: Eliminate clamp_and_resolve_freq()drivers/cpufreq/cpufreq.c+2 -100 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchChristian LoehleSultan Alsawaf
1/6R-b R-b
2/6R-b
3/6R-b
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] cpufreq/sched: Improve synchronization of policy limits updates with schedutil

Hi Everyone,

This is an update of

https://lore.kernel.org/linux-pm/[email protected]/

that replaces the first patch with a better fix and adds one more patch after the second one.

The original cover letter is still generally applicable:

"This series of patches has been inspired by the discussion following a bug
report regarding the patch at

https://lore.kernel.org/lkml/[email protected]/

and its attempted unsuccessful resolution:

https://lore.kernel.org/linux-pm/[email protected]/

which basically leads to the conclusion that cpufreq policy limits updates are not sufficiently synchronized with the scheditil governor, especially in the fast switching case in which running the driver callback is the only way to make the new policy limits take effect.

The purpose of this series is to address this concern."

Patch [1/6] is a fix for the issue introduced by the patch linked above (please see the patch changelog for details), for 6.15-rc. The remaining patches are for 6.16.

Patch [2/6] adds memory barriers in two places in schedutil along with some WRITE_ONCE()/READ_ONCE() annotations to ensure that policy limits updates will not be missed due to reordering of instructions.

Patch [3/6] prevents limits_changed from being used for purposes unrelated to changing the policy limits.

Patch [4/6] is a preparatory function rename with no functional impact.

Patch [5/6] updates the cpufreq core to avoid situations in which cpufreq_driver_resolve_freq(), called by schedutil, may see intermediate values of policy->min and policy->max and makes that function address the unlikely case in which it may see policy->min > policy->max.

Patch [6/6] cleans up the code after the previous changes.

Please see individual patch changelogs for details.

Thanks!