Skip to content

PM / ACPI: sleep: Additional changes related to suspend-to-idle

Rafael J. Wysocki linux-acpi linux-pm lkml 3 versions – In review

Get series with b4
b4 am 5997740.FPbUVk04hV@kreacher

Versions newest first · linked by author and title

  1. v3 Latest8 patches 15 repliesIn review
  2. v28 patches 0 repliesSuperseded
  3. v14 patches 1 replySuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8ACPI: PM: Set up EC GPE for system wakeup from drivers that need itdrivers/acpi/ec.c drivers/acpi/internal.h drivers/acpi/sleep.c +4 more+45 -220 replies
2/8ACPI: PM: s2idle: Rearrange lps0_device_attach()drivers/acpi/sleep.c+17 -150 replies
3/8ACPI: PM: s2idle: Add acpi.sleep_no_lps0 module parameterdrivers/acpi/sleep.c+15 -160 replies
4/8ACPI: PM: s2idle: Switch EC over to polling during "noirq" suspenddrivers/acpi/ec.c+2 -40 replies
5/8ACPI: PM: s2idle: Eliminate acpi_sleep_no_ec_events()drivers/acpi/ec.c drivers/acpi/internal.h drivers/acpi/sleep.c+1 -120 replies
6/8ACPI: EC: PM: Consolidate some code depending on PM_SLEEPdrivers/acpi/ec.c drivers/acpi/internal.h+27 -290 replies
7/8ACPI: EC: PM: Make acpi_ec_dispatch_gpe() print debug messagedrivers/acpi/ec.c+5 -10 replies
8/8ACPI: PM: s2idle: Execute LPS0 _DSM functions with suspended devicesdrivers/acpi/sleep.c include/linux/suspend.h kernel/power/suspend.c+35 -153 replies

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy ShevchenkoKai-Heng FengRajneesh Bhardwaj
SeriesT-b A-b T-b
1/8R-b
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/8] PM / ACPI: sleep: Additional changes related to suspend-to-idle

Hi All,

Quoted 20 lines
Quoted 7 lines

On top of the "Simplify the suspend-to-idle control flow" patch series posted previously:

https://lore.kernel.org/lkml/71085220.z6FKkvYQPX@kreacher/

sanitize the suspend-to-idle flow even further.

Quoted 8 lines

First off, decouple EC wakeup from the LPS0 _DSM processing (patch 1).

Next, reorder the code to invoke LPS0 _DSM Functions 5 and 6 in the specification-compliant order with respect to suspending and resuming devices (patch 2).

Finally, rearrange lps0_device_attach() (patch 3) and add a command line switch to prevent the LPS0 _DSM from being used.

The v2 is because I found a (minor) bug in patch 1, decided to use a module parameter instead of a kernel command line option in patch 4. Also, there are 4 new patches:

Quoted 8 lines

Patch 5: Switch the EC over to polling during "noirq" suspend and back during "noirq" resume.

Patch 6: Eliminate acpi_sleep_no_ec_events().

Patch 7: Consolidate some EC code depending on PM_SLEEP.

Patch 8: Add EC GPE dispatching debug message.

The v3 is just a rearranged v2 so as to move the post sensitive patch (previous patch 2)
to the end of the series. [After applying the full series the code is the same as before.]

For easier testing, the series (along with some previous patches depended on by it) is available in the pm-s2idle-testing branch of the linux-pm.git tree at kernel.org:

https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/log/?h=pm-s2idle-testing

Please refer to the changelogs for details.

Thanks,
Rafael