Skip to content

OMAPDSS: use components (fix probing problems)

Laurent Pinchart linux-arm-kernel linux-fbdev linux-omap 1 version New

Get series with b4
b4 am 358618591.Y41I6t5qpX@avalon

Versions newest first

  1. v1 Latest0 of 7 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchLaurent Pinchart
SeriesA-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] OMAPDSS: use components (fix probing problems)

Hi Tomi,

Thank for the patches.

Quoted 12 lines · On Tuesday 16 June 2015 13:16:22 Tomi Valkeinen wrote:

Hi,

I noticed that on some platforms omapdss did not probe successfully. Some resource was not available yet, but omapdss did not manage to handle deferred probing. The reason was the use of platform_driver_probe() in combination with how the omapdss module handles the drivers.

To fix this properly, the component system felt fine for the job, and it seems to work nicely.

Tomi

Quoted 8 lines

Tomi Valkeinen (7):
OMAPDSS: move 'dss_initialized' to dss driver
OMAPDSS: refactor dss probe function
OMAPDSS: fix dss_init_ports error handling
OMAPDSS: remove uses of __init/__exit
OMAPDSS: reorder uninit calls
OMAPDSS: componentize omapdss
OMAPDSS: simplify submodule reg/unreg code

I've quickly reviewed the whole series and it looks good to me.

Acked-by Laurent Pinchart <[email protected]>
Quoted 12 lines
 drivers/video/fbdev/omap2/dss/core.c  |  80 ++++--------
 drivers/video/fbdev/omap2/dss/dispc.c |  42 +++++--
 drivers/video/fbdev/omap2/dss/dpi.c   |  36 ++++--
 drivers/video/fbdev/omap2/dss/dsi.c   |  27 +++-
 drivers/video/fbdev/omap2/dss/dss.c   | 223 ++++++++++++++++++++-----------
 drivers/video/fbdev/omap2/dss/dss.h   |  32 ++---
 drivers/video/fbdev/omap2/dss/hdmi4.c |  28 ++++-
 drivers/video/fbdev/omap2/dss/hdmi5.c |  28 ++++-
 drivers/video/fbdev/omap2/dss/rfbi.c  |  32 ++++-
 drivers/video/fbdev/omap2/dss/sdi.c   |  35 ++++--
 drivers/video/fbdev/omap2/dss/venc.c  |  31 +++--
 11 files changed, 396 insertions(+), 198 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart

Read the cover letter in its thread