Add generic set_rate clk_ops for PLL35xx and PLL36xx for samsung SoCs
Get series with b4
b4 am 3788098.20c4sNn9AM@amdc1227Versions newest first
- v7 Latest0 of 11 patches 0 repliesNew
Patches in v7 No applies recorded yet
None of the 11 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Tomasz Figa | Mike Turquette |
|---|---|---|
| Series | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 00/11] Add generic set_rate clk_ops for PLL35xx and PLL36xx for samsung SoCs
Hi Yadwinder, Vikas,
Quoted 9 lines · On Tuesday 11 of June 2013 15:01:05 Yadwinder Singh Brar wrote:
This patch series does the following:
1) Unifies the clk strutures and registration function used for PLL35xx
& PLL36xx, to factor out possible common code.2) Defines a common
rate_tablewhich will contain recommended p, m, s
and k values for supported rates that needs to be changed for changing corresponding PLL's rate
Quoted 6 lines
3) Adds
set_rate()andround_rate()clk_opsfor PLL35xx and PLL36xxchanges since v6:
- Splited the patch addingsamsung_clk_register_pll()into definition addition, SoC specific migration and cleanup patches.
- Addressed some NIT comments.
This version looks good to me. Thanks for your work on improving this series again!
Best regards,
Tomasz
Quoted 16 lines
changes since v5:
- Corrected to use rate table as specified in UM for exynos5250 epll.
- Took care of exynos5420 as well, as new exynos5420 clk driver came in while rebasing on latest Kgene's for-next.Since we spilted 1st patch into 2 different patches, can we expect "reviewed-by" again for the same?
changes since v4:
- Defined common samsungsamsung_clk_register_pll()to register a list of PLL and used a structsamsung_pll_clockfor passing intialisation data instead of passing as arguments. Now passing LOCK as well as CON0 offset as intialisation data.
- Calculated length of rate table while registering PLL instead of getting it as intialisation data.
Quoted 6 lines
changes since v3:
- Used__clk_lookup()instead of adding alias formout_vpllsrc
- Added check for changing only M value insamsung_pll36xx_set_rate()
- Modifiedsamsung_pll35xx_mp_change()&samsung_pll35xx_set_rate()to improve readabilty.
- Made the inputrate_tableas__init_datawhich is to be provided
while
Quoted 47 lines
registering PLL and made a copy of that table while registering, so that if multiple tables are their, they can be freed after getting the P, M, S, K setting values from required one.
changes since v2:
- Added new patch to reorder the MUX registration formout_vpllsrcMUX before the PLL registrations. And to add the alias for themout_vpllsrc
MUX. - Added a check to confirm parent rate while registrating the PLL rate tables.changes since v1:
- removed sorting and bsearch
- modified the definition of struct "samsung_pll_rate_table"
- added genericround_rate()
- rectified the ops assignment for "rate table passed as NULLIs rebased on branch kgene's "for-next"
https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/log/
?h=for-nextVikas Sajjan (3):
clk: samsung: Addset_rate()clk_opsfor PLL36xx
clk: samsung: Reorder MUX registration formout_vpllsrc
clk: samsung: Add EPLL and VPLL freq table for exynos5250 SoCYadwinder Singh Brar (8):
clk: samsung: Introduce a commonsamsung_clk_pllstruct
clk: samsung: Define a commonsamsung_clk_register_pll()
clk: samsung: Migrate exynos5250 to use common
samsung_clk_register_pll()
clk: samsung: Migrate exynos4 to use common
samsung_clk_register_pll()
clk: samsung: Migrate exynos5420 to use common
samsung_clk_register_pll()
clk: samsung: Remove unused pll registeration code for pll35xx andpll36xxclk: samsung: Add support to register
rate_tablefor samsung plls
clk: samsung: Addset_rate()clk_opsfor PLL35xxdrivers/clk/samsung/clk-exynos4.c | 40 +++-- drivers/clk/samsung/clk-exynos5250.c | 101 +++++++++-- drivers/clk/samsung/clk-exynos5420.c | 86 ++++++--- drivers/clk/samsung/clk-pll.c | 339 ++++++++++++++++++++++++++-------- drivers/clk/samsung/clk-pll.h | 38 ++++- drivers/clk/samsung/clk.h | 53 ++++++ 6 files changed, 519 insertions(+), 138 deletions(-)