Skip to content

spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

Vignesh Raghavendra u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH RFT 0/3] spi-nor: spi-nor-ids: Fix 4 Byte addressing for n25q256 and n25q512*

Hi Simon,

Quoted 10 lines · Simon Goldschmidt

Hi Vignesh,

Quoted 7 lines · Vignesh Raghavendra

This series removes SPI_NOR_4B_OPCODES flags from legacy variants of n25q256* and n25q512* and adds entries for newer variants of those flashes that support 4 Byte opcodes.

I don't have the flash devices. So its only compile tested.

Quoted 9 lines
Quoted 5 lines

Ashish, Simon,

I would greatly appreciate if you could test these patches and make sure 4 Byte opcodes are being used. (Probably by enabling/adding prints to cmd->opcode in spi_mem_exec_op() in drivers/spi/spi-mem.c

As written in my last mail, I currently cannot get SFDP to work on my board:
I keep getting 0xffdddfdf instead of 0x50444653 (SFDP_SIGNATURE).

Did it ever work on your board ie did you test it when you were testing my patches porting SPI NOR framework from kernel?

What's the controller driver? Cadence QSPI?

Regards
Vignesh

Quoted 28 lines

Any idea for a reason of that? That device I have here seems to be equipped with an MT25QL256ABA, but that should not be an issue, I think.

Regards,
Simon

Quoted 22 lines

Euginey,

Could you test this series on top of latest u-boot master and confirm that your test cases still work?

Regards
Vignesh

Vignesh Raghavendra (3):
spi-nor: spi-nor-ids: Disable SPI_NOR_4B_OPCODES for n25q512* and

    n25q256*
  spi-nor: spi-nor-ids: Rename mt25qu512a entry
  spi-nor: spi-nor-ids: Add entries for newer variants of n25q256* and
    n25q512*
 drivers/mtd/spi/spi-nor-ids.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--
2.23.0

Signature · 2 lines
Regards
Vignesh