Skip to content

kconfig: cleanups, documentation updates, and one bug fix

Martin Walch linux-kbuild lkml 1 version In review

Get series with b4
b4 am 3926659.JuuXvBGSjN@tacticalops

Versions newest first

  1. v2 Latest5 patches 6 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5kconfig: add short explanation to SYMBOL_WRITEscripts/kconfig/expr.h+1 -10 replies
2/5kconfig: fix trivial typos and update mconf documentationscripts/kconfig/mconf.c scripts/kconfig/menu.c scripts/kconfig/symbol.c+31 -332 replies
3/5kconfig: adjust warning message for conflicting typesscripts/kconfig/menu.c+4 -31 reply
4/5kconfig: remove unused definition from scannerscripts/kconfig/zconf.l+0 -10 replies
5/5kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->lenscripts/kconfig/menu.c+1 -12 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchJean DelvareWang YanQingBenjamin Poirier
1/5
2/5R-b R-b
3/5A-b
4/5
5/5A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/5] kconfig: cleanups, documentation updates, and one bug fix

In this second attempt, I tried to incorporate all replies I received for the first version of this patch set:

PATCH 1: kconfig: add short explanation to SYMBOL_WRITE
Ignore this one as long as there is no clear conclusion about the purpose of SYMBOL_WRITE. I only include it, so the patch numbers do not change and there is no "hole" in the patch set.

PATCH 2: kconfig: fix trivial typos and update mconf documentation
In the first place, this corrected only three typos. Now this patch corrects all bad occurrences of "tell" instead of "tells" and fixes several more spelling mistakes. Furthermore some changes that have been made to mconf during the last years are now also updated in the documentation.

PATCH 3: kconfig: adjust warning message for conflicting types
Now explicitely state that the second type is being ignored.

PATCH 4: kconfig: remove unused definition from scanner
No changes since the first version.

PATCH 5: kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len
As I do not think it is worth to make this a separate patch, I appended this fix for a bug that is only triggered by the search function of mconf.

Martin Walch (5):
kconfig: add short explanation to SYMBOL_WRITE
kconfig: fix trivial typos and update mconf documentation
kconfig: adjust warning message for conflicting types
kconfig: remove unused definition from scanner
kconfig: fix bug in search results string: use strlen(gstr->s), not

    gstr->len
 scripts/kconfig/expr.h   |  2 +-
 scripts/kconfig/mconf.c  | 60 +++++++++++++++++++++++-------------------------
 scripts/kconfig/menu.c   | 11 +++++----
 scripts/kconfig/symbol.c |  2 +-
 scripts/kconfig/zconf.l  |  1 -
 5 files changed, 37 insertions(+), 39 deletions(-)
Signature · 1 line
1.8.1.5