Skip to content

x86/mm/cpa: Further optimizations

Dave Hansen lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 8 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] x86/mm/cpa: Further optimizations
Quoted 3 lines · Peter Zijlstra

Dave, can you have a wee look at the Atom errata thing; this does grow the amount of code between the page-table update and the TLB flush a bit, but all that PTI crud we did a while back already made it a non-trivial amount of code.

Oh, were you worried that the act of sending the IPIs widens the window vs. just doing the local flush? We definitely do the smp_call_function() dance *before* we do the local TLB invalidation in in on_each_cpu().

But, the existing flush was not a "true" fix anyway. It just tended to work around things.

If the issue pops back up, I'd prefer that we just do:

	__flush_tlb_all();
	flush_tlb_all();

Preferably with an actual model/family check for the "AAH41" workaround.
The real value of what you did was moving the flush_tlb_all() closer,
and that remains either way.