Skip to content

r8169: factor out firmware handling

Heiner Kallweit netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- fix small whitespace issue in patch 2

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2r8169: rename r8169.c to r8169_main.cdrivers/net/ethernet/realtek/Makefile drivers/net/ethernet/realtek/r8169_main.c+1 -00 replies
2/2r8169: factor out firmware handlingdrivers/net/ethernet/realtek/Makefile drivers/net/ethernet/realtek/r8169_firmware.c drivers/net/ethernet/realtek/r8169_firmware.h +1 more+274 -2410 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 0/2] r8169: factor out firmware handling

Let's factor out firmware handling into a separate source code file. This simplifies reading the code and makes clearer what the interface between driver and firmware handling is.

v2:
- fix small whitespace issue in patch 2

Heiner Kallweit (2):
r8169: rename r8169.c to r8169_main.c
r8169: factor out firmware handling

 drivers/net/ethernet/realtek/Makefile         |   1 +
 drivers/net/ethernet/realtek/r8169_firmware.c | 231 +++++++++++++++++
 drivers/net/ethernet/realtek/r8169_firmware.h |  39 +++
 .../realtek/{r8169.c => r8169_main.c}         | 243 +-----------------
 4 files changed, 274 insertions(+), 240 deletions(-)
 create mode 100644 drivers/net/ethernet/realtek/r8169_firmware.c
 create mode 100644 drivers/net/ethernet/realtek/r8169_firmware.h
 rename drivers/net/ethernet/realtek/{r8169.c => r8169_main.c} (97%)
Signature · 1 line
2.21.0