Skip to content

RFC add detailed error values to block layer

Mike Christie lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2add detailed error values to block layerdrivers/block/ll_rw_blk.c fs/bio.c include/linux/bio.h +1 more+34 -172 replies
2/2add detailed error values to block layerdrivers/block/cciss.c drivers/block/cpqarray.c drivers/block/ll_rw_blk.c +13 more+23 -220 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2][RFC] add detailed error values to block layer

I saw that the Adaptec RAID developers are in need of detailed IO error values too, so I wanted to post what I have so we can try to work together. I have converted the block layer, but have not finished the end request callers.

01-ec-core.patch just defines the error values, and modifies the request completion functions. Right now they just convert the uptodate status to an error value. Per Jeff's advice I did not define my own erronos. wrt his other comment, I was not sure if wanted me to print the error value in string form in __end_that_request, or just print the numerical value.

02-ec-bioendio.patch converts the bio_endio and bi_end_io callers to pass one of the error values defined above instead of the -Exxx.

Both patches were built against 2.6.5-rc1.

The block layer error values are not too exciting. There were very few drivers that did not just return EIO. The end request users will be much more fun :)

Thanks,

Mike Chrisite