Skip to content

: tc action cleanup + fixes

Patrick McHardy netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17: act_api.c whitespace cleanup+0 -00 replies
2/17: Consistent comparision style in act_api.c+0 -00 replies
3/17: Remove checks for impossible conditions in act_api.c+0 -00 replies
4/17: Check TCA_ACT_KIND payload size _before_ copying it+0 -02 replies
5/17: Clean up act_api.c action init path, propagate errors properly+0 -00 replies
6/17: Clean up gact action+0 -00 replies
7/17: Remove checks for impossible conditions in gact action+0 -00 replies
8/17: Return proper error codes in tcf_gact_init+0 -00 replies
9/17: Return -EOPNOTSUPP if gact probability is requested but not compiled in+0 -00 replies
10/17: Clean up ipt action+0 -00 replies
11/17: Remove checks for impossible conditions in ipt action+0 -02 replies
12/17: Fix missing unlock in ipt action error path+0 -00 replies
13/17: Clean up tcf_ipt_init+0 -00 replies
14/17: Clean up pedit action+0 -00 replies
15/17: Remove checks for impossible conditions in pedit action+0 -00 replies
16/17: Return proper error codes in tcf_pedit_init+0 -00 replies
17/17: Disable broken override bits in pedit action+0 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH PKT_SCHED 0/17]: tc action cleanup + fixes

Hi Jamal,

here is what I got so far, I'll continue tommorrow. Only compile tested yet. Please review and comment.

Patrick McHardy:
o [PKT_SCHED]: Disable broken override bits in pedit action
o [PKT_SCHED]: Return proper error codes in tcf_pedit_init
o [PKT_SCHED]: Remove checks for impossible conditions in pedit action
o [PKT_SCHED]: Clean up pedit action
o [PKT_SCHED]: Clean up tcf_ipt_init
o [PKT_SCHED]: Fix missing unlock in ipt action error path
o [PKT_SCHED]: Remove checks for impossible conditions in ipt action
o [PKT_SCHED]: Clean up ipt action
o [PKT_SCHED]: Return -EOPNOTSUPP if gact probability is requested
but not compiled in
o [PKT_SCHED]: Return proper error codes in tcf_gact_init
o [PKT_SCHED]: Remove checks for impossible conditions in gact action
o [PKT_SCHED: Clean up gact action
o [PKT_SCHED]: Clean up act_api.c action init path, propagate errors
properly
o [PKT_SCHED]: Check TCA_ACT_KIND payload size _before_ copying it
o [PKT_SCHED]: Remove checks for impossible conditions in act_api.c
o [PKT_SCHED]: Consistent comparision style in act_api.c
o [PKT_SCHED]: act_api.c whitespace cleanup

Regards
Patrick