Skip to content

: tc action cleanups

Patrick McHardy netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22: Restore net/sched/ipt.c After iptables Kmod Cleanupnet/ipv4/netfilter/ip_tables.c net/sched/ipt.c+40 -440 replies
2/22: act_api.c: whitespace and coding style cleanup+0 -00 replies
3/22: act_api.c: use consistent comparision style+0 -00 replies
4/22: act_api.c: remove checks for impossible conditions+0 -00 replies
5/22: act_api.c: remove unnecessary initializations+0 -00 replies
6/22: Add rtattr_strlcpy, use it where appropriateinclude/net/pkt_cls.h net/core/rtnetlink.c net/decnet/dn_dev.c +6 more+38 -490 replies
7/22: Use rtattr_strcmp where appropriatenet/decnet/dn_rules.c net/ipv4/devinet.c net/ipv4/fib_rules.c +1 more+4 -40 replies
8/22: act_api.c: clean up init path, propagate errors properly+0 -00 replies
9/22: tc actions: whitespace and coding style cleanupnet/sched/ipt.c net/sched/mirred.c net/sched/pedit.c +1 more+161 -1990 replies
10/22: tc actions: remove checks for impossible conditionsnet/sched/ipt.c net/sched/mirred.c net/sched/pedit.c +1 more+5 -560 replies
11/22: gact action: fix multiple bugs in init pathnet/sched/gact.c+34 -320 replies
12/22: ipt action: fix multiple bugs in init path+0 -00 replies
13/22: mirred action: fix multiple bugs in init path+0 -00 replies
14/22: pedit action: fix multiple bugs in init pathnet/sched/pedit.c+53 -280 replies
15/22: police action: fix multiple bugs in init path+0 -00 replies
16/22: ipt action: fix missing unlock on error path+0 -00 replies
17/22: tc actions: remove unnecessary locking for refcnt changes+0 -00 replies
18/22: ipt action: fix module refcnt underflow/mem leaks in tcf_ipt_cleanup+0 -00 replies
19/22: act_api.c: remove module loading from get/delete operations+0 -00 replies
20/22: act_api.c: push memory allocation to tcf_action_get_1+0 -00 replies
21/22: act_api.c: sync multi action order processing+0 -00 replies
22/22: Don't export ing_filternet/core/dev.c+0 -51 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH PKT_SCHED 0/22]: tc action cleanups

Hi Jamal,

following are the reorganized tc action cleanup patches with some additional fixes. Please review and comment, I would like to ask Dave to pull them in soon so I don't get more clashes.

bk-tree is at: bk://212.42.230.204/net-2.6-sched

Patrick McHardy:
o [PKT_SCHED]: Don't export ing_filter
o [PKT_SCHED]: act_api.c: sync multi action order processing
o [PKT_SCHED]: act_api.c: push memory allocation to tcf_action_get_1
o [PKT_SCHED]: act_api.c: remove module loading from get/delete operations
o [PKT_SCHED]: ipt action: fix module refcnt underflow/mem leaks in
tcf_ipt_cleanup
o [PKT_SCHED]: tc actions: remove unnecessary locking for refcnt changes
o [PKT_SCHED]: ipt action: fix missing unlock on error path
o [PKT_SCHED]: police action: fix multiple bugs in init path
o [PKT_SCHED]: pedit action: fix multiple bugs in init path
o [PKT_SCHED]: mirred action: fix multiple bugs in init path
o [PKT_SCHED]: ipt action: fix multiple bugs in init path
o [PKT_SCHED]: gact action: fix multiple bugs in init path
o [PKT_SCHED]: tc actions: remove checks for impossible conditions
o [PKT_SCHED]: tc actions: whitespace and coding style cleanup
o [PKT_SCHED]: act_api.c: clean up init path, propagate errors properly
o [RTNETLINK]: Use rtattr_strcmp where appropriate
o [RTNETLINK]: Add rtattr_strlcpy, use it where appropriate
o [PKT_SCHED]: act_api.c: remove unnecessary initializations
o [PKT_SCHED]: act_api.c: remove checks for impossible conditions
o [PKT_SCHED]: act_api.c: use consistent comparision style
o [PKT_SCHED]: act_api.c: whitespace and coding style cleanup

Rusty Russell:
o [PKT_SCHED]: Restore net/sched/ipt.c After iptables Kmod Cleanup

Read the cover letter in its thread