Skip to content

unify checkings for clean messages and fix indentation

Pablo Neira netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fix broken indentation in netlink.hinclude/linux/netlink.h+20 -133 replies
2/4introduce netlink_check_skb functioninclude/linux/netlink.h net/netlink/af_netlink.c+40 -04 replies
3/4make xfrm_user use netlink_check_skbnet/xfrm/xfrm_user.c+1 -280 replies
4/4make rtnetlink use netlink_check_skb+0 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] [NETLINK] unify checkings for clean messages and fix indentation

Hi,

The following patches introduce a new function that check that the netlink messages received are clean. Actually some people performs such checkings, some don't and others simply do some half of them. I think that we must unify the behaviour of a netlink socket when it has to reply to malformed messages. Attached an indentation fix for netlink.h as well.

00indent-fix.patch:
fixes broken indentation in netlink.h
01process_skb.patch:
introduces the new function called netlink_check_skb that does
the sanity checkings for received messages.
02xfrm.patch:
the modification to make xfrm_user use such new function.
03rtnetlink.patch:
same thing for rtnetlink.

The 02 and 03 patches are straightforward conversions. If you are ok with this, I could post more patches to make other netlink sockets use this new function.

--
Pablo