Skip to content

Fix 3ware irq handling

Jeff Garzik linux-ide linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Fix 3ware irq handling: correct IRQ_HANDLEDdrivers/scsi/3w-9xxx.c drivers/scsi/3w-xxxx.c+4 -40 replies
2/3Fix 3ware irq handling: remove bogus testdrivers/scsi/3w-9xxx.c drivers/scsi/3w-xxxx.c+2 -40 replies
3/3Fix 3ware irq handling: update irq handler indentationdrivers/scsi/3w-9xxx.c drivers/scsi/3w-xxxx.c+253 -2571 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Fix 3ware irq handling
Quoted 7 lines · Mark Lord
Quoted 1 line

"irq XX: nobody cared" is a screaming interrupt situation, which could

have 1001 causes.

Speaking of which. The 3ware drivers appear to have a bug in their handling of this. They *always* report "handled=1" from their interrupt routines, regardless of whether it was their hardware or not that was signalling for attention.

Thanks for pointing this out, Mark.

What follows is a patch series to clean this up:

patch 1: only report IRQ_HANDLED when needed
patch 2: remove bogus "my irq == my irq" test
patch 3: fix indentation, after patch #2's change