Skip to content

libata PIO fixes (revised)

Albert Lee linux-ide 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3libata "if condition" enhancementdrivers/scsi/libata-core.c+5 -40 replies
2/3libata ata_data_xfer() fixdrivers/scsi/libata-core.c include/linux/libata.h+129 -131 reply
3/3libata handle the case when device returns/needs extra datadrivers/scsi/libata-core.c+23 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] libata PIO fixes (revised)

Jeff,

The PIO fixes revised according to the previous reviews.

1/3 pio1.diff:
- Modify the "if conditions" in __atapi_pio_bytes() to be more robust.

2/3 pio2.diff:
- Add ATA_FLAG_IO_32BIT to libata.h for hosts with 32-bit data register.
- Modify ata_mmio_data_xfer() and ata_pio_data_xfer() to handle buffer with length not aligned to 32-bit boundary.

3/3 pio3.diff:
- Modify __atapi_pio_bytes() to handle the case when device returns/needs extra data.

(Patch diff'ed against 2.6.13-rc4 tree, 02459eaab98a6a57717bc0cacede148fc76af881)

Tested ok on x86 with Promise PDC20275 and LG DVD-Multi drive.

For your review and advice, thanks.

Albert