Skip to content

phy: atheros: dt bindings and cleanup

Michael Walle u-boot 7 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 0 repliesNew
  2. v3 posting 2/20 of 12 patches 0 repliesSuperseded
  3. v3 posting 1/212 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v2 posting 3/30 of 12 patches0 repliesSuperseded
v2 posting 2/30 of 12 patches0 repliesSuperseded
v2 posting 1/312 patches0 repliesSuperseded
v10 of 9 patches0 repliesSuperseded

Changes in v4 from the cover letter

- add acked-by's, thanks Joe!

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12phy: atheros: Make RGMII Tx delays actually configurable for AR8035drivers/net/phy/atheros.c+0 -41 reply
2/12phy: atheros: Use common functions for RGMII internal delaysdrivers/net/phy/atheros.c+41 -281 reply
3/12phy: atheros: Clarify the configuration of the CLK_25M output pindrivers/net/phy/atheros.c+14 -51 reply
4/12phy: atheros: Explicitly disable RGMII delaysdrivers/net/phy/atheros.c+8 -01 reply
5/12phy: atheros: Clarify the intention of ar8021_configdrivers/net/phy/atheros.c+4 -41 reply
6/12phy: atheros: fix AR8021 PHY ID maskdrivers/net/phy/atheros.c+1 -11 reply
7/12phy: atheros: use defines for PHY IDsdrivers/net/phy/atheros.c+7 -31 reply
8/12phy: atheros: introduce debug read and write functionsdrivers/net/phy/atheros.c+41 -161 reply
9/12phy: atheros: move delay config to common functiondrivers/net/phy/atheros.c+22 -161 reply
10/12phy: atheros: add device tree bindings and configdoc/device-tree-bindings/net/phy/atheros.txt drivers/net/phy/atheros.c include/dt-bindings/net/qca-ar803x.h+270 -21 reply
11/12phy: atheros: ar8035: remove static clock configdrivers/net/phy/atheros.c+0 -131 reply
12/12phy: atheros: consolidate {ar8031|ar8035}_config()drivers/net/phy/atheros.c+3 -271 reply

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchJoe Hershberger
1/12A-b
2/12A-b
3/12A-b
4/12A-b
5/12A-b
6/12A-b
7/12A-b
8/12A-b
9/12A-b
10/12A-b
11/12A-b
12/12A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/12] phy: atheros: dt bindings and cleanup

This patch series superseeds the following two:
From Vladimir Oltean
https://patchwork.ozlabs.org/cover/1031360/
From me:
https://patchwork.ozlabs.org/cover/1184507/

Although the first is marked as accepted into u-boot-net I guess it was removed due to broken boards ("DT as ABI", RGMII delay was fixed and thus breaks the board).

After disussing with Vladimir, I've integrated his patches with this series. Also the first one
Address packet drops at low traffic rate due to SmartEEE feature
was dropped because it will likely be fixed by making u-boot support the eee-broken-X device tree properties. Apart from that, only the subject was changed and a note about possible board breakage was added the patch which changes the delay behaviour.

For all of those, who will test this patchset, the device tree binding needs the phydev->node property, which needs to be set in every network driver. If the device tree binding is not working for you have a look at the
ar803x_of_init: found PHY node: phy at 0
output. In the case above "phy at 0" is the phy node in the device tree. If instead the node of your network device is displayed, you have to set the phydev->node property in your network device driver.

For the fsl_enetc driver this patchset will add it:
https://patchwork.ozlabs.org/cover/1188043/

changes since v3:
- add acked-by's, thanks Joe!

changes since v2:
- rebased onto latest master, esp. #include <dm/device_compat.h>

changes since v1:
- pull all Vladimirs Oltan's patches and rebase mine onto them
- fix the CLK_25M settings for the AR8035
- add two new patches "fix AR8021 PHY ID mask" and "use defines for PHY IDs"
- use the new kernel device tree binding for the AR803x PHYs:
https://patchwork.ozlabs.org/patch/1188293/
- add debugging output

Michael Walle (7):
phy: atheros: fix AR8021 PHY ID mask
phy: atheros: use defines for PHY IDs
phy: atheros: introduce debug read and write functions
phy: atheros: move delay config to common function
phy: atheros: add device tree bindings and config
phy: atheros: ar8035: remove static clock config
phy: atheros: consolidate {ar8031|ar8035}_config()

Vladimir Oltean (5):
phy: atheros: Make RGMII Tx delays actually configurable for AR8035
phy: atheros: Use common functions for RGMII internal delays
phy: atheros: Clarify the configuration of the CLK_25M output pin
phy: atheros: Explicitly disable RGMII delays
phy: atheros: Clarify the intention of ar8021_config

 doc/device-tree-bindings/net/phy/atheros.txt |  35 ++
 drivers/net/phy/atheros.c                    | 350 ++++++++++++++++---
 include/dt-bindings/net/qca-ar803x.h         |  13 +
 3 files changed, 345 insertions(+), 53 deletions(-)
 create mode 100644 doc/device-tree-bindings/net/phy/atheros.txt
 create mode 100644 include/dt-bindings/net/qca-ar803x.h
Signature · 1 line
2.20.1