Skip to content

change TCP protoinfo via netlink

Pablo Neira netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Nest TCP protocol private infoinclude/linux/netfilter/nfnetlink_conntrack.h net/ipv4/netfilter/ip_conntrack_proto_tcp.c+12 -10 replies
2/3change TCP state via nfnetlinkinclude/linux/netfilter_ipv4/ip_conntrack_protocol.h net/ipv4/netfilter/ip_conntrack_proto_tcp.c+26 -00 replies
3/3Implement private protocol info changingnet/ipv4/netfilter/ip_conntrack_netlink.c+42 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] change TCP protoinfo via netlink

Taken from [1]:

I think that users must be able to set the TCP state of a conntrack, otherwise if they create a conntrack via libnfnetlink_conntrack, the state will be set to NONE. If users aren't able to set the state, I'd consider that the library is kind of incomplete. I don't like the idea of kidding with stuff that could be compromising either, but I don't want to lose any features. So, I think that the solution is *remark* in the documentation of libnfnetlink_conntrack and the conntrack manpage that changing the protocol private information like the state could result in problems, I'll to do such thing.

[1]https://lists.netfilter.org/pipermail/netfilter-devel/2005-August/020784.html

@Harald: I've reworked the patches as you suggested.

--
Pablo

Read the cover letter in its thread