Skip to content

sa1100fb updates

Bartlomiej Zolnierkiewicz linux-arm-kernel linux-fbdev 1 version New

Get series with b4
b4 am 4330027.F5ASplytpk@amdc3058

Versions newest first

  1. v1 Latest0 of 8 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] sa1100fb updates
Quoted 15 lines · Russell King - ARM Linux
Quoted 14 lines · Bartlomiej Zolnierkiewicz
Quoted 1 line · Russell King - ARM Linux

Hi Bart,

Hi Russell,

Quoted 9 lines

This series updates the sa1100fb fbdev driver's initialisation paths to be more robust. In doing these updates, I realised that we omitted to free some memory which was allocated for the framebuffer if initialisation fails - something that was hidden due to the complex cleanup that the driver performs. Switching to managed resources made this more obvious.

Tested on H3600 iPAQ and Assabet.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
 drivers/video/fbdev/sa1100fb.c | 75 +++++++++++++++---------------------------
 drivers/video/fbdev/sa1100fb.h |  2 ++
 2 files changed, 29 insertions(+), 48 deletions(-)

I queued all patches for 4.15, thanks!

Now that 4.15-rc1 is out, something tells me that was not actually the case. Any ideas what happened?

Could you please explain the issue that you are seeing a bit more?

For me it looks all fine:

$ git log --oneline v4.15-rc1 drivers/video/fbdev/sa1100fb.c
cb6bc3f video: sa1100fb: move pseudo palette into sa1100fb_info structure
0ab7658 video: sa1100fb: fix video memory allocation leak
c244f8e video: sa1100fb: clean up failure path
5634cba video: sa1100fb: use devm_gpio_request_one()
f6fc8c9 video: sa1100fb: use devm_request_irq()
df6b228 video: sa1100fb: use devm_ioremap_resource()
e43064c video: sa1100fb: use devm_clk_get()
ba1d36b video: sa1100fb: use devm_kzalloc()
...

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics