Skip to content

Change xs_read_watch interfaces to support variable arguments

Anthony Liguori xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Change xs_read_watch interface to return a sized array (in userspace and in kernel).linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_xs.c tools/blktap/xenbus.c tools/console/daemon/io.c +5 more+115 -630 replies
2/2Update kernel watch API to pass the array of watch arguments to the callback instead of just passing the node.linux-2.6-xen-sparse/drivers/xen/balloon/balloon.c linux-2.6-xen-sparse/drivers/xen/blkback/xenbus.c linux-2.6-xen-sparse/drivers/xen/blkfront/blkfront.c +8 more+69 -320 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Change xs_read_watch interfaces to support variable arguments

The following set of changes modify the read_watch interface in userspace and in the kernel to support variable arguments. This is in preparation for adding domid to @{introduce,release}Domain watches. This will allow backends to automatically reap on domain destruction which should eliminate a large number of the zombie problems we're having on domain destruction since Xend no longer plays a role in freeing that memory.

The interface for read_watch is now consistent between userspace and kernel space. It's modelled after xs_read_directory. The returned array is indexable via XS_WATCH_* macros.

While slightly awkward, IMHO it seems like the cleanest and most flexible option of the proposed interfaces.

Regards,

Anthony Liguori