Skip to content

aic79xx: fix deadlock & cleanup

Hannes Reinecke linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3aic79xx: convert qfrozen to atomic_tdrivers/scsi/aic7xxx/aic79xx_osm.c drivers/scsi/aic7xxx/aic79xx_osm.h+11 -335 replies
2/3aic79xx: use tcq functionsdrivers/scsi/aic7xxx/aic79xx_osm.c+5 -90 replies
3/3aic79xx: Remove dead codedrivers/scsi/aic7xxx/aic79xx_core.c drivers/scsi/aic7xxx/aic79xx_osm.c drivers/scsi/aic7xxx/aic79xx_osm.h+0 -620 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] aic79xx: fix deadlock & cleanup

Hi all,

this patchset cleans up the aic79xx drivers.
- Convert qfrozen count to atomic_t type.
The qfrozen count is the low-level equivalent to the scsi-ml scsi_block_requests. Converting it to atomic_t gets rid of the ahd_lock / ahd_unlock and thereby removes some deadlocks in the recovery code.
- use scsi-ml tcq functions.
SCSI-Ml already provides some tcq funtions, so we might as well use them.
- remove dead code
Removing some dead code which have been left over.

The first patch should fix the deadlocks people were seeing during recovery. Emmanuel, could you test them whether your problem is resolved (and ignoring the 'overlapped command error handling', as this patchset replaces it).

Cheers,

Hannes

Signature · 9 lines
Dr. Hannes Reinecke			[email protected]
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html