Skip to content

dm/md sysfs dependency tree (rev.3)

Jun'ichi Nomura dm-devel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6kobject_add_dirinclude/linux/kobject.h lib/kobject.c+39 -00 replies
2/6add holders/slaves subdirectory to /sys/blockfs/partitions/check.c include/linux/genhd.h+30 -00 replies
3/6bd_claim_by_kobjectfs/block_dev.c include/linux/fs.h+197 -20 replies
4/6bd_claim_by_diskinclude/linux/genhd.h+13 -00 replies
5/6md to use bd_claim_by_diskdrivers/md/md.c+2 -00 replies
6/6dm to use bd_claim_by_diskdrivers/md/dm-table.c+10 -102 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] dm/md sysfs dependency tree (rev.3)

Hello,

This is an updated version of dm/md sysfs dependency tree patch set. For example, if dm-0 maps to sda, we'll have following symlinks;
/sys/block/dm-0/slaves/sda --> /sys/block/sda /sys/block/sda/holders/dm-0 --> /sys/block/dm-0

Thanks for Alasdair, Neil and Greg for reviews and comments. I think the patches get much better shape than before. I'm happy to hear any other comments for these patches.

Patches included are:

1. [PATCH 1/6] kobject_add_dir
Adding kobject_add_dir() function which creates a subdirectory for a given kobject.

2. [PATCH 2/6] add holders/slaves subdirectory to /sys/block Creating "slaves" and "holders" directories in /sys/block/<disk>, creating "holders" directory under /sys/block/<disk>/<partition>

3. [PATCH 3/6] bd_claim_by_kobject
Adding bd_claim_by_kobject() function which takes kobject as additional signature of holder device and creates sysfs symlinks between holder device and claimed device. bd_release_from_kobject() is a counter part of bd_claim_by_kobject.

4. [PATCH 4/6] bd_claim_by_disk
Variants which take gendisk instead of kobject and do kobject_{get,put}(&gendisk->kobj).

5. [PATCH 5/6] md to use bd_claim_by_disk
Use bd_claim_by_disk.

6. [PATCH 6/6] dm to use bd_claim_by_disk
Use bd_claim_by_disk.

Patches from 1 to 5 work both on 2.6.16-rc5 and 2.6.16-rc5-mm2. I hope them to be included in mm if there's no problem.

Patch 6 depends on dm-table-store-md.patch in
http://www.kernel.org/pub/linux/kernel/people/agk/patches/2.6/editing/.
The dm-table-store-md.patch might theoretically require some locking/release-ordering fixes in dm core which is under investigation though it's separate issue.

Thanks,

Signature · 1 line
Jun'ichi Nomura, NEC Solutions (America), Inc.