Skip to content

per-task delay accounting

Shailabh Nagar lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8SetupDocumentation/kernel-parameters.txt include/linux/delayacct.h include/linux/sched.h +7 more+210 -02 replies
2/8Sync block I/O and swapin delay collectioninclude/linux/delayacct.h include/linux/sched.h kernel/delayacct.c +2 more+59 -00 replies
3/8cpu delay collection via schedstatsinclude/linux/sched.h kernel/sched.c+56 -210 replies
4/8Utilities for genetlink usageinclude/net/genetlink.h+20 -00 replies
5/8taskstats interfaceDocumentation/accounting/taskstats.txt include/linux/taskstats.h include/linux/taskstats_kern.h +5 more+629 -39 replies
6/8delay accounting usage of taskstats interfaceinclude/linux/delayacct.h include/linux/taskstats.h init/Kconfig +2 more+109 -20 replies
7/8documentationDocumentation/accounting/delay-accounting.txt Documentation/accounting/getdelays.c Documentation/accounting/taskstats.txt+493 -00 replies
8/8/proc export of aggregated block I/O delaysfs/proc/array.c include/linux/delayacct.h kernel/delayacct.c+26 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Patch 0/8] per-task delay accounting

Here are the delay accounting patches again. I'm not using the earlier email thread due to code being refactored a bit.

The previous posting

    http://www.uwsg.indiana.edu/hypermail/linux/kernel/0603.3/1776.html

of these patches elicited several review comments from Andrew Morton all of which have been addressed.

The other main thread of the comments was whether other accounting stakeholders would be ok with this interface. Towards this end, I'd posted an overview of what the other packages do (which didn't seem to make the archives) and some of the stakeholders responded.

I'll repost the analysis as a reply to this post. Meanwhile, here's the list of the stakeholders identified by Andrew and a summary of status of their comments.

1. CSA accounting/PAGG/JOB: Jay Lan <[email protected]>

Raised several points

       http://www.uwsg.indiana.edu/hypermail/linux/kernel/0604.1/0397.html

all of which have been addressed in this set of patches.

2. per-process IO statistics: Levent Serinol <[email protected]>

No reponse.
I'd ascertained that its needs are a subset of CSA.

3. per-cpu time statistics: Erich Focht <[email protected]>

No response.
I'd ascertained that its needs can be met by taskstats interface whenever these statistics are submitted for inclusion.

4. Microstate accounting: Peter Chubb <[email protected]>

Mentioned overlap of patches with delay accounting
http://www.uwsg.indiana.edu/hypermail/linux/kernel/0603.3/2286.html

and also that a /proc interface was preferable due to convenience. My position is that the netlink interface is a superset of /proc due to former's ability to supply exit-time data.

5. ELSA: Guillaume Thouvenin <[email protected]>

Confirmed that ELSA is not a direct user of a new kernel statistics interface since it is a consumer of CSA or BSD accounting's statistics.

6. pnotify: Jes Sorensen <[email protected]>
(taken over pnotify from Erik Jacobson)

Informed over private email that pnotify replacement is being worked on.

I'd ascertained that pnotify (or its replacemenent) will not be concerned with exporting data to userspace or collecting any stats. Thats left to the kernel module that uses pnotify to get notifications. CSA is one expected user of pnotify. Hence CSA's concerns are the only ones relevant to pnotify as well.

7. Scalable statistics counters with /proc reporting:
Ravikiran G Thirumalai, Dipankar Sarma <[email protected]>

Confirmed these counters aren't relevant to this discussion.

--Shailabh

Series

delayacct-setup.patch
delayacct-blkio-swapin.patch
delayacct-schedstats.patch
genetlink-utils.patch
taskstats-setup.patch
delayacct-taskstats.patch
delayacct-doc.patch
delayacct-procfs.patch