Skip to content

RFC statistics infrastructure

Martin Peschke lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 20 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8statistics infrastructure - prerequisite: list operationinclude/linux/list.h+12 -00 replies
2/8statistics infrastructure - prerequisite: parser enhancementinclude/linux/parser.h lib/parser.c+62 -03 replies
3/8statistics infrastructure - prerequisite: timestampinclude/linux/jiffies.h kernel/printk.c+37 -440 replies
4/8statistics infrastructure - documentationDocumentation/00-INDEX Documentation/statistics.txt+766 -00 replies
5/8statistics infrastructureMAINTAINERS arch/s390/Kconfig arch/s390/oprofile/Kconfig +4 more+1793 -53 replies
6/8statistics infrastructure - exploitation: zfcpdrivers/s390/scsi/zfcp_ccw.c drivers/s390/scsi/zfcp_def.h drivers/s390/scsi/zfcp_erp.c +2 more+50 -30 replies
7/8statistics infrastructure - exploitation prerequisitearch/alpha/kernel/time.c arch/arm/kernel/time.c arch/arm/mach-omap1/time.c +25 more+31 -49 replies
8/8statistics infrastructure - exploitation: scsidrivers/scsi/scsi_lib.c drivers/scsi/scsi_scan.c drivers/scsi/scsi_sysfs.c +2 more+86 -20 replies

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchAndreas Herrmann
1/8
2/8
3/8
4/8
5/8
6/8A-b
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC] [Patch 0/8] statistics infrastructure

(This is a sequel. What happened in the last season:
http://marc.theaimsgroup.com/?l=linux-kernel&m=113458576022747&w=2)

My patch series is a proposal for a generic implementation of statistics. Envisioned exploiters include device drivers, and any other component. It provides both a unified programming interface for exploiters as well as a unified user interface. It comes with a set of disciplines that implement various ways of data processing, like counters and histograms.

The recent rework addresses performance issues and memory footprint, straightens some concepts out, streamlines the programming interface, removes some weiredness from the user interface, reduces the amount of code, and moves the exploitation according to last time's feedback.

A few more keywords for the reader's convenience:
based on per-cpu data; spinlock-free protection of data; observes cpu-hot(un)plug for efficient memory use; tiny state machine for switching-on, switching-off, releasing data etc.; configurable by users at run-time; still sitting in debugfs; simple addition of other disciplines.

Good places to start reading code are:

statistic_create(), statistic_remove() statistic_add(), statistic_inc()
struct statistic_interface, struct statistic struct statistic_discipline, statistic_*_counter() statistic_transition()

I'd suggest you skip anything that looks like string manipulation, and have a look at my humble attempt at a user interface once you are familiar with the base function.

Looking forward to your comments.

Martin