tagsize < 8kb restriction
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 13 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | removes the artificial restriction tagsize < 8kb from git-mktagcache.h mktag.c sha1_file.c | +7 | 1 reply | |
| 1/2 | Again: remove the artificial restriction tagsize < 8kbcache.h mktag.c sha1_file.c | +46 | 0 replies | |
| 2/2 | added more informative error messages to git-mktagmktag.c | +23 | 1 reply | |
| 2/2 | Again: add more informative error messages to git-mktagmktag.c | +16 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] tagsize < 8kb restriction
Hi,
I am currently working on an interface for source code quality assurance tools to automatically scan newly commited code. Since it is the only way to add data (scan-results) to an already-existing commit, I decided to use tags for that.
Since the scan-results will most definitly exeed the 8kb-limit, I would like to remove this artificial restriction.
I know I could also
git-hash-object -t tag -w
but prefer using the "official" way.
In order not to write duplicate code I used parts of index_pipe() in sha1_file.c
What I found odd when writing the patch was that main() in mktag.c uses xread() to read from stdin (which respects EAGAIN and EINTR return values), but index_pipe() in sha1_file.c just uses read() for doing merely the same thing. For unifying both routines i found that xread() might be the better choice.
Removing the restriction was pretty straightforward but do you think this would break something in other places ?
[PATCH 1/2]
remove the < 8kb restrinction from git-mktag
[PATCH 2/2]
add more informative error messages to git-mktag
Bj