Skip to content

gpio: 3 minor tweaks

Jim Cromie lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3gpio: drop vtable members .gpio_set_high .gpio_set_low gpio_set is enough.drivers/char/pc8736x_gpio.c drivers/char/scx200_gpio.c include/linux/nsc_gpio.h+0 -00 replies
2/3gpio: cosmetics - remove needless newlinesdrivers/char/nsc_gpio.c+0 -00 replies
3/3gpio: rename exported vtables to better match purposedrivers/char/pc8736x_gpio.c drivers/char/scx200_gpio.c+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [ patch -mm1 00/03 ] gpio: 3 minor tweaks

this patchset does:

1 - drops gpio_set_high, gpio_set_low from the nsc_gpio_ops vtable. While we can't drop them from scx200_gpio (or can we ?), vtable users (ie new users) dont need them, they can just use gpio_set()

2 - pure cosmetics - lose needless newlines.

3 - rename EXPORTed gpio vtables from {scx200,pc8736x}_access to _gpio_ops new name is much closer to the vtable-name struct nsc_gpio_ops, and should be clearer. Also rename the _fops vtable vars to _fileops to better disambiguate it from the gpio vtables.