pc87360 - fix unchecked
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 3 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [lm-sensors] [patch 0/3] pc87360 - fix unchecked
Quoted 8 lines · Jean Delvare
Jim,
Quoted 5 lines
Quoted 5 lines
More interesting would be a comparison of the
contents of/sys/class/hwmon/hwmon0/devicebefore and after the patches. If the contents differ, something's wrong, else everything should be OK - or at least there is no regression.
Quoted 10 lines
Quoted 4 lines
Your choice of words leaves me unsure whether this is an observation, or a requirement. In any case, its easy, so here it is, plus some other observations.
What difference does it make? I can't force you to do it, and I can't verify by myself. I can only hope that you want to provide good patches to the community, and will test your work as much as possible.
It seems I could also have chosen my wording a bit better ;-)
Quoted 28 lines
It's really about what you want to give to us, rather than what I request or suggest.
Quoted 2 lines
By contents, I assume you mean the files within the dir:
Yes.
Quoted 4 lines
diff sys-files-2.6.1*
51a52Quoted 1 line
subsystem@
No idea where this comes from, but not from your patch, for sure. I guess it's something new, I have such links on 2.6.18-rc4, but I don't remember seeing them before.
If that's the only difference it means your patch didn't omit any file, so it works as designed for your chip. Good.
Quoted 3 lines
One other thing / oddity I note (again on old kernel, and new/patched). Datestamps on the 'files' is not uniform.
Quoted 8 lines
Quoted 3 lines
IOW, there are 2 datestamps : Aug 20 23:39 and Aug 21 08:04
Yeah, I see similar patterns here. Looks like the files start with their creation time, then the timestamp gets updated when you write to (always) or read from them (first time only?)
only thing that chgs date is re-modding.
None of these affect the date.
sensors; sensors -s; cat /sys/class/hwmon/hwmon0/device/*
Quoted 5 lines
I can't explain it all, but it makes some sense, and I don't see any serious problem here anyway. Again, your patch can't have anything to do with this.
ack. Im also seeing this on laptop running fc4 kernel.
thanks