Skip to content

make newrole suid (take 3)

Michael C Thompson selinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8make newrole suid (take 3)newrole/Makefile newrole/newrole-lspp.pamd+42 -00 replies
2/8make newrole suid (take 3)newrole/newrole.c+64 -242 replies
3/8make newrole suid (take 3)newrole/newrole.c+26 -70 replies
4/8make newrole suid (take 3)newrole/newrole.c+127 -5111 replies
5/8make newrole suid (take 3)newrole/newrole.c+79 -1080 replies
6/8make newrole suid (take 3)newrole/newrole.c+163 -880 replies
7/8make newrole suid (take 3)newrole/newrole.c+274 -2180 replies
8/8make newrole suid (take 3)newrole/Makefile newrole/newrole.c+92 -730 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] make newrole suid (take 3)

This is the intro to a set of eight patches.

I finally took the time to break things down so that (I hope) more people read and give feedback (I can't believe only Stephen Smalley had comments, my code isn't that great!)

These patches are an attempt to make newrole be an acceptably secure suid root program, to provide it with the capabilities to generate audit records (existing) and handle polyinstatiation (new).

The format of the patches is different from previous sends.

The 8 patches are as follows:
1) Modifications to Makefile to support future patch needs Add newrole-lspp.pamd
2) New extract_pw_data function and use in main()
3) Add signal handler function
4) Update drop_capabilities() and use in main()
5) Update the authentication functions and use in main() Add cleanup since pam_start is now left till program end
6) Move relabeling tty actions into functions
7) Move command-line argument parsing into a function Clear the environment during execution
Add support for preserving the environment (-p)
8) Shift to using new defines in the Makefile and in newrole.c Add support for namespaces
Remove unused code, cleanup and documentation

It is now possible to apply a single patch and the code will compile; however, this is not recommended

The comments and discussions from the previous send (take 2) of these patches have been integrated.

Thanks,
Mike

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.