Skip to content

HP HSV200 update

Hannes Reinecke dm-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Use strmatch to load config filelibmultipath/config.c+20 -10 replies
2/3Implement 'revision' matchinglibmultipath/config.c libmultipath/config.h libmultipath/discovery.c+34 -130 replies
3/3Update HP HSV200 hardware table+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] HP HSV200 update

Hi Christophe,

this patchset implements a new field 'revision' for the hardware table, which is filled with the 'revision' field from the SCSI Inquiry. The reason for this is that HP switched the behaviour during a firmware update (ie from using START_STOP_UNIT to ALUA). And to support this properly we'll have to match against the 'revision' field, too.

In doing so I've found a bug in load_config(). Currently, we're loading
the default hardware table with comparing via regex. However, as the default table also contains regexp we'll end up comparing _two_ regexps, the outcome of which is a quite peculiar to say the least. We should rather be using a simple string match to avoid this pitfall.

So, this patchset does
- Correct load_config() to compare entries via string match
- Implements matching against the revision field
- Updates the hardware table for HP HSV200 support.

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke			[email protected]
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de