Skip to content

thermal: More separation between the core and drivers

Rafael J. Wysocki linux-pm lkml 3 versions – In review

Get series with b4
b4 am 4558251.LvFx2qVVIh@kreacher

Versions newest first · linked by author and title

  1. v3 Latest6 patches 13 repliesIn review
  2. v23 patches 4 repliesSuperseded
  3. v12 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6thermal: core: Move threshold out of struct thermal_tripdrivers/thermal/gov_fair_share.c drivers/thermal/gov_power_allocator.c drivers/thermal/thermal_core.c +7 more+78 -521 reply
2/6thermal: core: Make struct thermal_zone_device definition internaldrivers/thermal/thermal_core.h drivers/thermal/thermal_trace.h include/linux/thermal.h+89 -852 replies
3/6thermal: core: Rewrite comments in handle_thermal_trip()drivers/thermal/thermal_core.c+13 -132 replies
4/6thermal: core: Send trip crossing notifications at init time if neededdrivers/thermal/thermal_core.c+16 -211 reply
5/6thermal: core: Sort trip point crossing notifications by temperaturedrivers/thermal/thermal_core.c drivers/thermal/thermal_core.h+37 -61 reply
6/6thermal: core: Relocate critical and hot trip handlingdrivers/thermal/thermal_core.c+7 -84 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchLukasz LubaDaniel Lezcano
1/6R-b
2/6R-b A-b
3/6R-b A-b
4/6R-b
5/6R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] thermal: More separation between the core and drivers

Hi Everyone,

This is an update of

https://lore.kernel.org/linux-pm/4558384.LvFx2qVVIh@kreacher/

and

https://lore.kernel.org/linux-pm/2331888.ElGaqSPkdT@kreacher/

which rebases the first patch on top of 6.9-rc2, adds 3 patches and adjusts the third patch from v2.

The original description of the first two patches still applies:

Quoted 11 lines

Patch [1/2] is based on the observation that the threshold field in struct thermal_trip really should be core-internal and to make that happen it introduces a wrapper structure around struct thermal_trip for internal use in the core.

Patch [2/2] moves the definition of the new structure and the struct thermal_zone_device one to a local header file in the core to enforce more separation between the core and drivers.

The patches are not expected to introduce any observable differences in behavior, so please let me know if you see any of that.

Note that these patches were first sent before the merge window and have not really changed since then (except for a minor rebase of the first patch in this series). Moreover, no comments regarding the merit of these patches have been made shared, so if this continues, I will be considering them as good to go by the end of this week.

Patch [3/6] is a rewrite of comments regarding trip crossing and threshold computations.

Patch [4/6] updates the trip crossing detection code to consolidate the threshold initialization with trip crossing on the way up.

Patch [5/6] ([3/3] in v2) adds a mechanism to sort notifications and debug calls taking place during one invocation of __thermal_zone_device_update() so they always go in temperature order.

Patch [6/6] relocates the critical and trip point handling to avoid a redundant temperature check.

The series applies on top of 6.9-rc2 and I'm planning to create a test branch containing it.

Thanks!